Select the builder's roles from the supplied configs - #528
Open
0w3n-d wants to merge 1 commit into
Open
Conversation
This was referenced Aug 28, 2026
0w3n-d
force-pushed
the
od/builder-sim-role-step1
branch
from
August 28, 2026 13:08
81fdc94 to
3d9f7f7
Compare
--merging.config activates merging, the new --sim.config activates simulation, neither is a startup error. The relay signer loads only for merging. The simulation role boots the node only; its servers come later. Step 1 of #527. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0w3n-d
force-pushed
the
od/builder-sim-role-step1
branch
from
August 29, 2026 14:03
3d9f7f7 to
e71b386
Compare
This was referenced Aug 31, 2026
vladimir-ea
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #527 (step 1 of 10)
What this PR does
Gives
helix-buildera second selectable role: simulation. Roles come fromwhich config file is supplied.
--merging.configactivates merging and is nowoptional, the new
--sim.configactivates simulation, and neither is a startuperror. The relay signer loads only for merging, so a simulation-only deployment
needs no
RELAY_KEY.BuilderSpine::startblocks until its tiles stop, so merging still starts last.Merging-only behavior is unchanged.
What this PR deliberately does not do
No validation work. The simulation role boots the node, logs its listen
addresses, and stops. The servers arrive in step 9 and the ethrex pipeline in
steps 3 to 8, so
SimulationConfigis parsed but not yet consumed.Tests
Written first and signed off before implementation
(
crates/builder/src/config.rs,simulation_config_tests, 8 tests):sim-config.example.ymlparses; a minimal config gets its defaults.ssz_addrequal torpc_addris rejected.role, which is the observable form of "no
RELAY_KEYneeded".Smoke-tested on the binary: no config errors before the node boots;
--sim.configwithRELAY_KEYunset logsSimulation role active.just fmt-check,just testandcargo clippy --all-features --no-deps -- -D warningsare clean.
cargo clippy -p helix-builderreports 4 pre-existing errors insrc/engine/, none in the files this PR touches. CI'sjust clippypasses no-p/--workspace, so it only lintsdefault-membersand never covered them.Reviewer checklist
lint,unit-test) is green