Share the simulators' payment and disallow-list helpers from helix-common - #529
Open
0w3n-d wants to merge 1 commit into
Open
Share the simulators' payment and disallow-list helpers from helix-common#5290w3n-d wants to merge 1 commit into
0w3n-d wants to merge 1 commit into
Conversation
10 tasks
0w3n-d
force-pushed
the
od/sim-shared-payment-helpers-step2
branch
from
August 28, 2026 13:01
cac4f3b to
9bc8569
Compare
0w3n-d
force-pushed
the
od/sim-shared-payment-helpers-step2
branch
from
August 28, 2026 13:08
9bc8569 to
36f4e17
Compare
3 tasks
…mmon The disallow list's parsing and digest, and the Safe multiSend payment recognition, carry no reth types. Move them so the ethrex simulator uses the same code. The functions and their tests move verbatim. Step 2 of #527. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0w3n-d
force-pushed
the
od/sim-shared-payment-helpers-step2
branch
from
August 29, 2026 14:03
36f4e17 to
9165a12
Compare
0w3n-d
changed the title
vladimir-ea
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #527 (step 2 of 10)
Base branch:
od/builder-sim-role-step1(#528, step 1). Retarget todeveloponce that merges.
What this PR does
Moves two groups of reth-free helpers out of the reth simulator into
helix-common, so the ethrex simulator uses the same code rather than a secondcopy:
blacklist: the disallow list's parsing and its digest.payment: SafemultiSendpayment recognition, and itssol!block.Drops
helix-simulator's now-unusedsha2dependency.Behavior is unchanged. Every function moves verbatim, and
ValidationApi::parse_disallow_listbecomes a call to the free function.What this PR deliberately does not do
No ethrex code. The
paymenthalf waited on the #500 stack, which has nowmerged.
Tests
Both test modules move unchanged:
blacklist::blacklist_tests(3) andpayment::multisend_payment_tests(6). The address list loads all three entriesin both
0x-prefixed and bare form; an unchanged list reports no new digestregardless of
DashSetiteration order; an amended list reports a new one; amultiSendpayload's entries to the recipient are summed, and a non-delegatecalloperation, an absent recipient, unrelated calldata and a truncated payload each
yield zero.
just fmt-check,just testandcargo clippy --all-features --no-deps -- -D warningsare clean.
cargo clippy -p helix-commonreports 8 pre-existing errors inbeacon/,config.rsandhttp/, none in the added file.Reviewer checklist
lint,unit-test) is green