Separate heading semantics and expose exact timestamps - #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title now accepts an optional heading level independent of visual size, retaining existing defaults. Time components render semantic time elements with ISO datetime, a full timestamp tooltip, and screen-reader text. Bump the package to 0.22.0.
Validation: lint (existing warnings only), typecheck, production build, and both new Playwright semantic tests passed. Chrome verified identical 33px large-title styling for h1/h2 and exact time attributes with hidden accessible text; Final Chrome check confirmed the existing Welcome heading is h2 at 33px; only unrelated MetaMask extension errors appeared. Semantic tests also run in CI.
Fixes UI-53
Fixes UI-54
https://plane.flow.industries/flow/browse/UI-53
https://plane.flow.industries/flow/browse/UI-54
Related to UI-32: existing success button/badge contrast failures are recorded in https://github.com/flow-industries/ui/actions/runs/34234093921. Main already fails accessibility and visual test jobs: https://github.com/flow-industries/ui/actions/runs/34132618901 and https://github.com/flow-industries/ui/actions/runs/34132618986. Preserve the approved palette pending its contrast/baseline decision.