Publish shared Focus provider and practice picker - #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Game and Talk duplicate the Focus session provider and Practice picker. Publish an opt-in
@flow-industries/ui/focusentry point with an injected API/account boundary, controlled panel and picker, and localizable text. Use the published@flow-industries/id@0.22.0primitives; existing UI entry points do not import Focus.The provider clears private state on account changes, rejects stale completions, restores sessions and retains successful study data when a companion request fails. Hosts retain guest and embed policy. Includes an isolated lazy-loaded showcase and API documentation.
Validation:
bun run lint,bun run typecheck,bun run build./#focus: keyboard search/category/custom subject, start/pause/resume/finish, paused reload, guest/account privacy, error retry, 390px light/dark layout with no horizontal overflow. Console errors observed were wallet-extension errors, not application errors.Release: UI 0.23.0 follows the concurrently published 0.22.0. Verify automatic publication before adopting in Talk/Game. Consumer handler, popup focus-restoration, embed and bundle-delta acceptance remains in those adoption PRs.
Also fixes the inherited success-text CI regression at the user's request: light green text now measures 5.24:1 on the soft green background (previously 2.47:1); dark styling is preserved. Both themes pass the contrast scan. Rendered and visually inspected updated component baselines using the pinned Linux Playwright image. Focus regression tests now run in the A11y workflow.
Fixes UI-50
https://plane.flow.industries/flow/browse/UI-50
Related to FLOW-12
https://plane.flow.industries/flow/browse/FLOW-12