Skip to content

feat(sort): Add sort option#41

Open
thaiat wants to merge 1 commit into
expressjs:masterfrom
thaiat:master
Open

feat(sort): Add sort option#41
thaiat wants to merge 1 commit into
expressjs:masterfrom
thaiat:master

Conversation

@thaiat

@thaiat thaiat commented Nov 23, 2015

Copy link
Copy Markdown

A small PR to allow configuring sort
Fixes #35

@dgershman

Copy link
Copy Markdown

would love to this feature.

@micahstubbs

Copy link
Copy Markdown

just tested this, works great for me ✅

looks like the CI is failing from some unrelated dependency reasons.

@micahstubbs

Copy link
Copy Markdown

would be really cool if @dougwilson or one of the other maintainers could take another look at this PR and get it in 😄

@dougwilson

Copy link
Copy Markdown
Contributor

I can't merge something that doesn't at least pass CI. If the OP or someone can update this PR (or make a new one) that does not fail in CI that would be the best way to get it to land 👍

@dougwilson

Copy link
Copy Markdown
Contributor

Also, shouldn't the sort apply to all the output types, not just the html output?

@micahstubbs

Copy link
Copy Markdown

[not OP, but] good question, wasn't aware that there was output other than html 💡

will see if I can help get a better understanding of why the CI is failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort options

4 participants