Skip to content

feat(sort): Add sort option - micah/35/sort#75

Open
micahstubbs wants to merge 12 commits into
expressjs:masterfrom
micahstubbs:micah/35/sort
Open

feat(sort): Add sort option - micah/35/sort#75
micahstubbs wants to merge 12 commits into
expressjs:masterfrom
micahstubbs:micah/35/sort

Conversation

@micahstubbs

Copy link
Copy Markdown

A small PR that adds user-configurable sort for html outputs

Fix #35

a fork of @thaiat's nice PR #41 with a small amount of additional work to get the Travis CI and Appveyor tests to pass.

@micahstubbs

Copy link
Copy Markdown
Author

yea, done. thought it might be related to the linting problem, looks like it's not now. thanks for watching this one 😄

and also, thanks for introducing to me https://github.com/eslint/eslint-plugin-markdown had never noticed this particular eslint plugin before

@micahstubbs

Copy link
Copy Markdown
Author

🎉 hooray, tests are green

@dougwilson

Copy link
Copy Markdown
Contributor

Nice! I'm pretty much about to go to sleep for work in the morning and will take a look as soon as I can and get this feature landed 😴

@micahstubbs

micahstubbs commented Aug 23, 2018

Copy link
Copy Markdown
Author

@dougwilson is there anything I can do to improve this PR?

@dougwilson

Copy link
Copy Markdown
Contributor

I will take a look when I get to a computer.

@brianreeve

Copy link
Copy Markdown

Are there any plans to merge this PR? Easily sorting by date would be very beneficial.

@micahstubbs

Copy link
Copy Markdown
Author

know that @dougwilson was busy back in August, but maybe, just maybe there's a bit more reviewer bandwidth here in the new year 😄

@mhamann

mhamann commented Feb 18, 2019

Copy link
Copy Markdown

@dougwilson i could use this too. any chance on a merge?

@mayeaux

mayeaux commented Jul 2, 2019

Copy link
Copy Markdown

Ring ring? Sorely missing feature!

@lwouis

lwouis commented Jul 17, 2019

Copy link
Copy Markdown

@dougwilson Click the button ;)

@dougwilson

Copy link
Copy Markdown
Contributor

The sort option should apply to all the response types not just the html one.

@micahstubbs

micahstubbs commented Jul 18, 2019

Copy link
Copy Markdown
Author

looks like the Appveyor node 1.8 env flaked out on us 😢

let's see if I can trigger a second test run 🤔

https://ci.appveyor.com/project/dougwilson/serve-index/builds/26065525
Screen Shot 2019-07-18 at 12 51 57 AM

@micahstubbs

Copy link
Copy Markdown
Author

🎉 tests are green. should be ready for another look @dougwilson 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sort options

7 participants