Add Google Pay golden request tests - #985
Merged
Max Harrison (maxharrison) merged 1 commit intoAug 24, 2026
Merged
Conversation
|
This was referenced Aug 20, 2026
Max Harrison (maxharrison)
force-pushed
the
max/gpay-golden-requests
branch
from
August 20, 2026 16:02
ab19539 to
06c22a2
Compare
This was referenced Aug 20, 2026
Max Harrison (maxharrison)
changed the base branch from
master
to
max/gpay-omit-billing-address-parameters-v2
August 20, 2026 16:03
ana-maksimovskikh
approved these changes
Aug 24, 2026
ana-maksimovskikh
left a comment
ana-maksimovskikh
left a comment
Contributor
There was a problem hiding this comment.
Thanks Max Harrison (@maxharrison) - the change looks good 🙌
The web Google Pay request had no structural fixture tests, so a default or a configured field could drift from the Android SDK without a focused failure. googlePayGoldenRequest.test.ts compares the full request projection with billing-disabled, billing-enabled, and custom fixtures. The fixtures are excluded from Prettier so they stay byte-identical to the Android copies in evervault/evervault-pay.
Max Harrison (maxharrison)
force-pushed
the
max/gpay-golden-requests
branch
from
August 24, 2026 12:47
06c22a2 to
ee22e91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The web Google Pay request had no whole-request test, so defaults and configured fields could change without a focused failure.
googlePayGoldenRequest.test.tsnow compares billing-disabled, billing-enabled, and custom requests with JSON fixtures.The fixture type derives from
buildPaymentRequest, so the projection stays tied to the production return type. A separate test covers web-onlymerchantId,merchantOrigin, andcallbackIntentsfields.The fixtures match the Android SDK copies byte-for-byte, but no CI check enforces that yet.
Stacked on #987.