Skip to content

Omit Google Pay billingAddressParameters when billing is not required - #986

Merged
Max Harrison (maxharrison) merged 0 commit into
max/gpay-golden-requestsfrom
max/gpay-omit-billing-address-parameters
Aug 20, 2026
Merged

Omit Google Pay billingAddressParameters when billing is not required#986
Max Harrison (maxharrison) merged 0 commit into
max/gpay-golden-requestsfrom
max/gpay-omit-billing-address-parameters

Conversation

@maxharrison

Copy link
Copy Markdown
Contributor

Stacked on #985. Review that first.

buildPaymentRequest always sent billingAddressParameters, even when billingAddressRequired was false:

"billingAddressRequired": false,
"billingAddressParameters": { "format": "FULL", "phoneNumberRequired": false }

Google ignores the parameters when billingAddressRequired is false, so the payment sheet does not change. The request still claimed a FULL address format that we never asked for, which is misleading in logs and in support tickets.

Omitting the field makes the request state only what it means, and makes billing-disabled.json identical to the Android fixture.

Not a breaking change for merchants. The only visible effect is one fewer field on the wire, shown here as the fixture diff.

@maxharrison
Max Harrison (maxharrison) requested a review from a team as a code owner August 20, 2026 15:54
@changeset-bot

changeset-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6683704

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maxharrison

Copy link
Copy Markdown
Contributor Author

Reopened as #987 after the stack was reordered. GitHub auto-closed this one as merged into its former stack base; nothing landed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant