Omit Google Pay billingAddressParameters when billing is not required - #986
Merged
Max Harrison (maxharrison) merged 0 commit intoAug 20, 2026
Conversation
|
Max Harrison (maxharrison)
force-pushed
the
max/gpay-golden-requests
branch
from
August 20, 2026 16:02
ab19539 to
06c22a2
Compare
Max Harrison (maxharrison)
deleted the
max/gpay-omit-billing-address-parameters
branch
August 20, 2026 16:02
Max Harrison (maxharrison)
force-pushed
the
max/gpay-omit-billing-address-parameters
branch
from
August 20, 2026 16:02
6683704 to
dbbf173
Compare
Contributor
Author
|
Reopened as #987 after the stack was reordered. GitHub auto-closed this one as merged into its former stack base; nothing landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #985. Review that first.
buildPaymentRequestalways sentbillingAddressParameters, even whenbillingAddressRequiredwas false:Google ignores the parameters when
billingAddressRequiredis false, so the payment sheet does not change. The request still claimed aFULLaddress format that we never asked for, which is misleading in logs and in support tickets.Omitting the field makes the request state only what it means, and makes
billing-disabled.jsonidentical to the Android fixture.Not a breaking change for merchants. The only visible effect is one fewer field on the wire, shown here as the fixture diff.