Skip to content

perf(gui): memoize Monero subaddress rows#1005

Draft
shriram-svg wants to merge 1 commit into
eigenwallet:masterfrom
shriram-svg:fix-727-subaddress-row-renders
Draft

perf(gui): memoize Monero subaddress rows#1005
shriram-svg wants to merge 1 commit into
eigenwallet:masterfrom
shriram-svg:fix-727-subaddress-row-renders

Conversation

@shriram-svg
Copy link
Copy Markdown

Summary

  • Extract the Monero subaddress table row into a memoized component.
  • Stabilize the label-change handler with useCallback.
  • Keep unchanged rows from re-rendering while editing one subaddress label, which avoids rebuilding address/copy/balance cells for the whole list on every keystroke.

Validation

  • corepack yarn install --immutable
  • corepack yarn eslint src/renderer/components/pages/monero/SubaddressesModal.tsx --quiet
  • PATH="$HOME/.cargo/bin:$PATH" corepack yarn gen-bindings
  • corepack yarn tsc
  • git diff --check

Bounty: #727. If this is accepted for a bounty award, I can provide the payout address requested by the maintainer.

@Einliterflasche
Copy link
Copy Markdown

Per our AI policy we require all communication to be exclusively human written. Until this requirement is met, we can't spare the effort to review this. Violations of this rule will result in a ban.

@Einliterflasche Einliterflasche marked this pull request as draft May 12, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants