feat(editor-compatibility): implement T19-01 published-post schema compatibility (#550) - #601
Conversation
…mpatibility and crash containment
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
This PR introduces a new editor compatibility checking system for Substack's ProseMirror/Tiptap schema validation. The implementation includes analyzer logic, profile definitions, normalization utilities, canary testing infrastructure, and integration into the prepublish workflow. The code is well-structured with proper TypeScript typing and no merge-blocking defects identified. All logic appears correct, error handling is appropriate, and there are no security vulnerabilities detected.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2082bbb92
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Implements Conductor track T19-01 (Published-post editor schema compatibility and crash containment) across all 5 phases (resolving #550, #555, #556, #557, #558, #559):
fixtures/prosemirror/editor-compatibility/:cover-control.json: paragraph-only control (0 tables, 0 tableHeader).rich-pilot-control.json: rich published pilot reproduction (0 tables, rich blocks).me-001throughme-006) containing exactly 11 tables and 41tableHeadernodes across the Season 1 corpus.PUBLIC_RENDER_PROFILE,PRIMARY_EDITOR_PROFILE(rejectstableHeader), andAUXILIARY_EDITOR_PROFILE(rejects rich blocks).editorCompatibility.substack-publisher schema compatibility <file> [--normalize-tables] [--upstream-repro <dir>].normalizeTablesToAccessibleListscontingency converts tables to accessible labelled lists, resolving primary editor rejection while preserving text content.runDisposableEditorCanaryenforces isolated, no-email, no-publication invariants with cleanup receipts.generateMinimalUpstreamReproductionPackageproduces clean minimal synthetic reproduction package for Substack engineers.Validation
npm run ci-> Biome 0 errorsnpm run typecheck-> Clean, 0 errorsnpm run knip-> Clean, 0 issuesnode scripts/github-programme.mjs check-> 100% validnpm run verify:agent-> 125 test files / 988 passedGoverned by #550, #555, #556, #557, #558, #559.