Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/components/event_details_component.rb
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# Renders the detail list shown at the top of an event page. Admin: true adds
# operator-only rows (user, timestamps, expiry).
class EventDetailsComponent < ViewComponent::Base
def self.for(event, admin: false)
new(event: event, admin: admin)
end

def initialize(event:, admin: false)
@event = event
@admin = admin
Expand Down
2 changes: 1 addition & 1 deletion app/views/admin/events/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<%= render Admin::EventDescriptionComponent.for(@event) %>
<% end %>

<%= render EventDetailsComponent.for(@event, admin: true) %>
<%= render EventDetailsComponent.new(event: @event, admin: true) %>

<% if @referenced_posts.any? %>
<section class="space-y-4" data-key="events.imported_posts">
Expand Down
2 changes: 1 addition & 1 deletion app/views/events/show.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<%= render EventDescriptionComponent.for(@event) %>
<% end %>

<%= render EventDetailsComponent.for(@event) %>
<%= render EventDetailsComponent.new(event: @event) %>

<% if @referenced_posts.any? %>
<section class="space-y-4" data-key="events.imported_posts">
Expand Down
10 changes: 2 additions & 8 deletions test/components/event_details_component_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,10 @@ def feed
@feed ||= create(:feed, user: user, name: "Test Feed")
end

test ".for should return the base component" do
event = create(:event, type: "generic_event")

assert_instance_of EventDetailsComponent, EventDetailsComponent.for(event)
end

test "#call should render the created timestamp without admin extras" do
event = create(:event, type: "owned_event", level: :warning, subject: feed)

result = render_inline(EventDetailsComponent.for(event))
result = render_inline(EventDetailsComponent.new(event: event))

assert_includes result.to_html, "Created"
assert_empty result.css('[data-key="admin.event.user"]')
Expand All @@ -28,7 +22,7 @@ def feed
test "#call should render a compact user link when admin" do
event = create(:event, type: "owned_event", user: user, subject: feed)

result = render_inline(EventDetailsComponent.for(event, admin: true))
result = render_inline(EventDetailsComponent.new(event: event, admin: true))
link = result.css("a[data-key='admin.event.user']").first

assert_equal event.user_id.to_s.last(5), link.text
Expand Down