Skip to content

Remove EventDetailsComponent factory alias#1083

Merged
dreikanter merged 5 commits into
mainfrom
agent/f060-remove-event-details-factory
Jul 18, 2026
Merged

Remove EventDetailsComponent factory alias#1083
dreikanter merged 5 commits into
mainfrom
agent/f060-remove-event-details-factory

Conversation

@dreikanter

Copy link
Copy Markdown
Owner

Changes:

  • Remove the EventDetailsComponent.for alias.
  • Instantiate the component directly at both call sites.
  • Remove the alias-only test and update rendering tests.

Why:

The factory method only forwarded to .new and performed no dispatch or configuration.

References:

Checks:

  • Existing component tests continue to cover normal and admin rendering.
  • GitHub Actions will verify the branch.

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.55%. Comparing base (ce0547a) to head (c37edc7).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
- Coverage   97.55%   97.55%   -0.01%     
==========================================
  Files         355      355              
  Lines        8358     8356       -2     
==========================================
- Hits         8154     8152       -2     
  Misses        204      204              
Files with missing lines Coverage Δ
app/components/event_details_component.rb 78.12% <ø> (-1.29%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dreikanter
dreikanter marked this pull request as ready for review July 18, 2026 21:56
@dreikanter
dreikanter merged commit ae0c23b into main Jul 18, 2026
14 checks passed
@dreikanter
dreikanter deleted the agent/f060-remove-event-details-factory branch July 18, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant