Skip to content

devonfw/IDEasy#1050: Introduce dependencies.json for LazyDocker#38

Merged
hohwille merged 5 commits intodevonfw:masterfrom
AdemZarrouki:feature/1050-add-lazydocker-dependencies
Apr 21, 2026
Merged

devonfw/IDEasy#1050: Introduce dependencies.json for LazyDocker#38
hohwille merged 5 commits intodevonfw:masterfrom
AdemZarrouki:feature/1050-add-lazydocker-dependencies

Conversation

@AdemZarrouki
Copy link
Copy Markdown
Contributor

@AdemZarrouki AdemZarrouki commented Apr 13, 2026

This pull request adds a dependencies.json file to the lazydocker/lazydocker directory that can be used instead of hardcoded dependency: https://github.com/devonfw/IDEasy/blob/4f2e37bf602a341666d12b62b09b633cbda05487/cli/src/main/java/com/devonfw/tools/ide/tool/lazydocker/LazyDocker.java#L35-L52

This fixes issue devonfw/IDEasy#1050

@AdemZarrouki AdemZarrouki self-assigned this Apr 13, 2026
@AdemZarrouki AdemZarrouki marked this pull request as ready for review April 13, 2026 15:18
@AdemZarrouki AdemZarrouki requested a review from hohwille April 13, 2026 15:18
@hohwille hohwille changed the title #1050: Introduce dependencies.json for LazyDocker devonfw/IDEasy#1050: Introduce dependencies.json for LazyDocker Apr 14, 2026
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdemZarrouki thanks for your PR. 👍
Did you read my comment?
I would suggest to remove the docker-compose dependency.

Comment thread lazydocker/lazydocker/dependencies.json Outdated
Comment thread lazydocker/lazydocker/dependencies.json Outdated
@hohwille
Copy link
Copy Markdown
Member

I will merge this after devonfw/IDEasy#1818 is merged and will soon be released.

@hohwille hohwille merged commit afba4fe into devonfw:master Apr 21, 2026
2 checks passed
hohwille added a commit that referenced this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants