Skip to content

#1050: add lazydocker dependencies#1818

Merged
hohwille merged 6 commits intodevonfw:mainfrom
AdemZarrouki:feature/1050-add-lazydocker-dependencies
Apr 21, 2026
Merged

#1050: add lazydocker dependencies#1818
hohwille merged 6 commits intodevonfw:mainfrom
AdemZarrouki:feature/1050-add-lazydocker-dependencies

Conversation

@AdemZarrouki
Copy link
Copy Markdown
Contributor

@AdemZarrouki AdemZarrouki commented Apr 13, 2026

This PR fixes #1050

Implemented changes:


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Apr 13, 2026
@AdemZarrouki AdemZarrouki self-assigned this Apr 13, 2026
@AdemZarrouki AdemZarrouki marked this pull request as ready for review April 13, 2026 15:28
@AdemZarrouki AdemZarrouki moved this from 🆕 New to Team Review in IDEasy board Apr 13, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 13, 2026

Coverage Report for CI Build 24733203100

Coverage increased (+0.07%) to 70.673%

Details

  • Coverage increased (+0.07%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 38 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

38 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/LocalToolCommandlet.java 37 80.26%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%

Coverage Stats

Coverage Status
Relevant Lines: 15199
Covered Lines: 11195
Line Coverage: 73.66%
Relevant Branches: 6760
Covered Branches: 4324
Branch Coverage: 63.96%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

@hohwille hohwille changed the title Feature/1050 add lazydocker dependencies #1050: add lazydocker dependencies Apr 14, 2026
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdemZarrouki thanks for the PR. 👍
Can you also remove installDependencies() method from parent class since this was the last override of this method and we want to entirely get rid of this obsolete feature?

Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdemZarrouki thanks. Now everything is perfect and ready for merge. 👍

@github-project-automation github-project-automation Bot moved this from Team Review to 👀 In review in IDEasy board Apr 21, 2026
@hohwille hohwille added this to the release:2026.05.001 milestone Apr 21, 2026
@hohwille hohwille added lazydocker dependencies dependencies.json (if tool A requires tool B) docker docker and esp. DockerDesktop labels Apr 21, 2026
@hohwille hohwille merged commit 29fa827 into devonfw:main Apr 21, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies dependencies.json (if tool A requires tool B) docker docker and esp. DockerDesktop lazydocker

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Introduce dependencies.json for LazyDocker and remove hardcoded dependency

3 participants