Skip to content

fix: preserve row thickTop - #8

Merged
developer0hye merged 1 commit into
fix/panic-safety-v2from
fix/read-row-thick-top-v2
Aug 29, 2026
Merged

fix: preserve row thickTop#8
developer0hye merged 1 commit into
fix/panic-safety-v2from
fix/read-row-thick-top-v2

Conversation

@developer0hye

Copy link
Copy Markdown
Owner

Summary

  • store and parse the OOXML row thickTop flag instead of dropping it
  • expose v2-compatible get_thick_top / set_thick_top accessors
  • write the flag back during XLSX serialization
  • cover the full OOXML attribute round trip with a unit test

This is the v2 compatibility port consumed by office2pdf. The corresponding current-upstream change is MathNya#359.

Verification

  • cargo test --lib (38 passed)
  • cargo clippy --lib -- -D warnings
  • rustfmt --check src/structs/row.rs

Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
@developer0hye
developer0hye merged commit 2e3a94a into fix/panic-safety-v2 Aug 29, 2026
1 check passed
@developer0hye
developer0hye deleted the fix/read-row-thick-top-v2 branch August 29, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant