XLSX: account for thick row borders in printed tracks - #1384
Merged
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
umya-spreadsheetv2 dropsthickTop; upstream support is proposed in fix: preserve row thickTop MathNya/umya-spreadsheet#359 and merged into the workspace's v2 fork in fix: preserve row thickTop umya-spreadsheet#8thickTopand the preceding automatic row'sthickBot, after the font-dependent row-track mappingcustomHeightrows unchanged because their declared tracks already include those boundaries, with a regression against the native monthly-budget chart sizeRelated issue
Related: #1228
Testing
Some(17.0)instead of18/19/17/19/19/17/17/17/17cargo fmt --checkcargo test -p office2pdf --lib -- parser::xlsx::tests— 275 passedcargo test -p office2pdf --lib -- parser::xlsx::row_boundaries::tests— 2 passedcargo test -p office2pdf --test xlsx_fixtures— 206 passedcargo clippy --workspace --all-targets -- -D warningscargo publish --dry-run -p office2pdf --allow-dirty— packaged library verified against public crates.io dependenciespython3 scripts/compare_layout.py ... --page 1 --noise-floor 0.5 --audit— after: 0.00pt mean/worst baseline delta, 0.00pt pitch delta, no large shiftspython3 scripts/compare_render.py ... --page 1 --dpi 150 --artifacts-dir ... --linesmagick compare -metric AE -fuzz 5% ...— page-1 AE fell from 132,379 pixels (6.29253%) before to 35,937 (1.70824%) afterafter.jpgsource rastergit diff --checkVisual impact
Visual audit
tests/fixtures/xlsx/SH107-9-x-9-Formatted-Table.xlsxpdftoppm, 150 DPIfixassets/bugfixes/issue-1228/gt.jpgassets/bugfixes/issue-1228/before.jpgassets/bugfixes/issue-1228/after.jpgVisual comparison
Required inspection
The hairline inventory covers every light-blue cell rule, the dark double outlines around Col5/1.5, and the orange rules under Col8/1.8; all are present at the matching positions and none uses a dash pattern. The emphasis inventory confirms the bold header labels, italic Col6/1.6, bold 1.4, and underlined orange runs. The remaining page-1 diff clusters are text colour/raster placement covered by #1230 and #1233, plus accepted antialiasing; #1229 covers the inkless second page outside the evidence page.
Deviation audit
Checklist
Signed-off-byline