fix clippy error - #95
Merged
Merged
Conversation
seyyed-dev
force-pushed
the
fix-clippy-errors
branch
from
July 20, 2026 16:06
cefedd6 to
836a6a6
Compare
Merged
oli-obk
reviewed
Jul 20, 2026
Comment on lines
225
to
+228
| match style { | ||
| SpanMode::Close { .. } | SpanMode::PostClose => { | ||
| if indent > 0 && (indent + 1) % config.wraparound == 0 { | ||
| self.indent_buf.push_str(&prefix); | ||
| for _ in 0..(indent % config.wraparound * config.indent_amount) { | ||
| self.indent_buf.push_str(LINE_HORIZ); | ||
| } | ||
| self.indent_buf.push_str(LINE_OPEN); | ||
| self.indent_buf.push('\n'); | ||
| SpanMode::Close { .. } | SpanMode::PostClose | ||
| if indent > 0 && (indent + 1) % config.wraparound == 0 => | ||
| { |
Collaborator
There was a problem hiding this comment.
could even make it a let chain now, removing another level of indentation
Contributor
Author
There was a problem hiding this comment.
This way?
if let SpanMode::Close { .. } | SpanMode::PostClose = style {
if indent > 0 && (indent + 1) % config.wraparound == 0 {
// ... body ...
Contributor
Author
There was a problem hiding this comment.
ok it is merged!
Collaborator
There was a problem hiding this comment.
Yea, progress is good, didn't want to block your PR
oli-obk
reviewed
Jul 20, 2026
| OutputConflictHandling::Error | ||
| }; | ||
|
|
||
| let config = Config { |
Collaborator
There was a problem hiding this comment.
oh we'll probably want to bump the version, too
oli-obk
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.