add span duration option - #96
Merged
Merged
Conversation
seyyed-dev
force-pushed
the
span-duration
branch
from
July 20, 2026 17:32
643b3cb to
e84a564
Compare
oli-obk
reviewed
Jul 20, 2026
Collaborator
There was a problem hiding this comment.
This is mostly a copy of an existing test, right? Could either use revisions on it or just edit it outright so we just have the small diff showing what changes when you enable closing durations
Contributor
Author
There was a problem hiding this comment.
* 6387b74 update tests
* 372b1d4 copy tests
seyyed-dev
force-pushed
the
span-duration
branch
from
July 21, 2026 12:55
e84a564 to
6387b74
Compare
seyyed-dev
commented
Jul 21, 2026
Comment on lines
+8
to
+10
| 1:main ├─123ms DEBUG duration connected | ||
| 1:main ├─123ms DEBUG duration message received, length=2 | ||
| 1:main ┌┘duration::conn peer_addr="82.9.9.9", port=42381 duration=123ms |
Contributor
Author
There was a problem hiding this comment.
Observation: duration=123ms is the part that we want. ├─123ms is a side effect of calling with_timer. with_timer is required to show the duration, and without it, the duration is not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please first merge #95, then this one