Skip to content

fix: sanitize subprocess call in run_crew.py #5713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix: sanitize subprocess call in run_crew.py #5713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/crewai/src/crewai/cli/run_crew.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from enum import Enum
import subprocess
import asyncio

import click
from packaging import version
Expand Down Expand Up @@ -69,16 +69,18 @@ def execute_command(
env[CREWAI_TRAINED_AGENTS_FILE_ENV] = trained_agents_file

try:
subprocess.run(command, capture_output=False, text=True, check=True, env=env) # noqa: S603
subprocess_run(
command, capture_output=False, text=True, check=True, env=env, shell=False
)

except subprocess.CalledProcessError as e:
except CalledProcessError as e:
handle_error(e, crew_type)

except Exception as e:
click.echo(f"An unexpected error occurred: {e}", err=True)


def handle_error(error: subprocess.CalledProcessError, crew_type: CrewType) -> None:
def handle_error(error: CalledProcessError, crew_type: CrewType) -> None:
"""
Handle subprocess errors with appropriate messaging.

Expand Down