fix: sanitize subprocess call in run_crew.py#5713
Open
orbisai0security wants to merge 1 commit intocrewAIInc:mainfrom
Open
fix: sanitize subprocess call in run_crew.py#5713orbisai0security wants to merge 1 commit intocrewAIInc:mainfrom
orbisai0security wants to merge 1 commit intocrewAIInc:mainfrom
Conversation
The CLI modules run_crew
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
lib/crewai/src/crewai/cli/run_crew.py.Vulnerability
V-001lib/crewai/src/crewai/cli/run_crew.py:72Description: The CLI modules run_crew.py, train_crew.py, and cli.py invoke subprocess.run() with Bandit S603 security warnings explicitly suppressed using 'noqa: S603' comments. The 'command' variable passed to these calls is constructed from CLI arguments or configuration values. If user-controlled input such as crew names, task parameters, or environment variables is incorporated into the command list without strict allowlist validation, an attacker can inject shell metacharacters or additional commands. The deliberate suppression of Bandit warnings indicates these calls were flagged and the warnings were silenced rather than the underlying issue resolved, suggesting the security risk was known but deferred.
Changes
lib/crewai/src/crewai/cli/run_crew.pyVerification
Automated security fix by OrbisAI Security