test: bump expected manifest image count#208
Open
matjic wants to merge 1 commit into
Open
Conversation
release_mici and release_tizi dropped to 32 partitions (no userdata_30); release_tici still has 33. The hardcoded 33 assertion was failing in CI for any branch built off master.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on master has been failing on
src/utils/manifest.test.js:41(expected 32 to be 33) since openpilot'srelease-miciandrelease-tizimanifests dropped one partition (userdata_30). Bumps the assertion to match current reality:release_mici: 32 partitionsrelease_tizi: 32 partitionsrelease_tici: 33 partitions (unchanged)Worth a follow-up to consider whether this tripwire should remain a hardcoded count (it has now failed twice for non-bug reasons) or become a minimum/structural check — the per-image xz tests and
countGpt === 6already cover most "missing image" cases. Out of scope here.Test plan
bun run testpasses the manifest count assertion for all three branches