warn about computer USB ports on port 2 in connect instructions#207
Open
matjic wants to merge 1 commit into
Open
warn about computer USB ports on port 2 in connect instructions#207matjic wants to merge 1 commit into
matjic wants to merge 1 commit into
Conversation
Computer USB ports (including high-end laptops) don't always deliver reliable sustained power for flashing. Steer users to a dedicated power adapter and warn about the computer-port pitfall.
Author
|
Author
|
build fix (unrelated to changes in this PR) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The connect-instructions screen currently says "Connect port 2 to your computer or a power brick," presenting the two options as equivalent. In practice, computer USB ports — even on high-end laptops — don't always deliver reliable sustained power for flashing. Issue #185 is an example of this behavior. I had the same issue with my comma 4 plugged into a MacBook Pro
Rather than quote a wattage figure (we couldn't find an authoritative one on the shop pages or in docs.howtocomma.com, and the obvious 5V/2A threshold doesn't actually filter out real-world failure cases), this just steers users toward a dedicated power adapter and flags the computer-port pitfall.
Example issue discord message: https://discord.com/channels/469524606043160576/1436852432503046294/1454311864640213165
Test plan
bun run test(theApp.test.jsxrendering test still passes; the pre-existingmanifest.test.jsmismatch is unrelated)bun dev→ click Start → pick a device → verify the new text reads correctly on the connect screen for both comma 3/3X and comma four