refactor(server-nestjs): rename permission services to disambiguate#2314
Merged
Conversation
shikanime
force-pushed
the
shikanime/push-tllzrlnzllmu
branch
from
44fc1d3 to
94fdf70
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
shikanime
force-pushed
the
shikanime/push-tllzrlnzllmu
branch
from
94fdf70 to
75609f2
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
shikanime
force-pushed
the
shikanime/push-tllzrlnzllmu
branch
from
75609f2 to
b4f31cd
Compare
- UserService → UserPermissionService - UserPolicy → UserPermissionPolicy - ProjectService → ProjectPermissionService - ProjectPolicy → ProjectPermissionPolicy - ProjectLoaderService → ProjectPermissionLoaderService Resolves naming collision with domain services. Deployment module updated.
shikanime
force-pushed
the
shikanime/push-tllzrlnzllmu
branch
from
b4f31cd to
591008c
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
approved these changes
Jul 15, 2026
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (26.70% Estimated after merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestJS dependency injection error messages do not explicitly indicate which module has the DI problem. When a generic name like
ProjectServiceis used in multiple modules (e.g.,ProjectServicefor domain logic vs.ProjectServicefor permissions), the error messages become ambiguous and debugging becomes difficult. By making permission service names explicit (ProjectPermissionService), the DI errors immediately identify the problematic module and service.Issues liées
Extrait de #2298
Quel est le comportement actuel ?
Quel est le nouveau comportement ?
Cette PR introduit-elle un breaking change ?
Autres informations