feat(server-nestjs): align plugin services with autoSync and suspende…#2298

Open

shikanime wants to merge 3 commits into

mainfrom

shikanime/push-plkxvsyoplqv

shikanime commented Jul 8, 2026 •

edited

Loading

Member

Issues liées

Quel est le comportement actuel ?

Avant cette PR, la synchronisation des projets par les plugins (ArgoCD, GitLab, Vault, Keycloak, Nexus, SonarQube, Harbor) était soit globale, soit déclenchée uniquement par les modifications apportées dans la Console. Les projets ne disposaient d'aucune option permettant de contrôler finement la synchronisation projet par projet.

Quel est le nouveau comportement ?

Cette PR introduit les options autoSync (désactivée par défaut) et suspended (activée par défaut) au niveau projet pour l'ensemble des 7 plugins. Elle réactive les tâches planifiées horaires (@Cron(CronExpression.EVERY_HOUR)) qui ne ciblent désormais que les projets autoSync=enabled ET suspended!=enabled via la méthode getAutoSyncProjects().

Comportement de synchronisation :

syncProject() vérifie désormais isSuspended() et ignore le projet si vrai (avec journalisation d'avertissement).
Les tâches planifiées utilisent getAutoSyncProjects() à la place de getAllProjects().

Nouveaux utilitaires :

isSuspended(project) — indique si le projet a l'option suspended activée.
isAutoSync(project) — indique si le projet a l'option autoSync activée.

Couche données :

getAutoSyncProjects() — filtre les projets avec autoSync=enabled ET suspended!=enabled.

Configuration des plugins :

Centralisation des clés de configuration dans des constantes *_PLUGIN_KEY (PLUGIN_NAME, AUTO_SYNC_PLUGIN_KEY, SUSPENDED_PLUGIN_KEY) pour les 7 plugins.
Ajout des interrupteurs suspended et autoSync au niveau projet pour ArgoCD, GitLab, Vault, Keycloak, Nexus, SonarQube et Harbor.

shikanime added this to the 9.20.0 milestone

shikanime requested a review from KepoParis

July 8, 2026 09:41

shikanime self-assigned this

shikanime added enhancement tech labels

github-actions Bot added the built label

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime closed this

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 28c085b to e635708 Compare

July 8, 2026 09:53

shikanime reopened this

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch 2 times, most recently from c862f6e to 560cac3 Compare

July 8, 2026 10:15

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 560cac3 to 1923518 Compare

July 8, 2026 11:14

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 1923518 to f8e527d Compare

July 8, 2026 12:37

github-code-quality Bot found potential problems

View reviewed changes

apps/server-nestjs/src/modules/gitlab/gitlab-datastore.spec.ts Fixed

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from f8e527d to f18eb6a Compare

July 8, 2026 13:00

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch 2 times, most recently from 6f5697d to 9583d0e Compare

July 8, 2026 13:20

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch 2 times, most recently from be6563a to 89f46f6 Compare

July 8, 2026 13:23

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment

github-actions Bot commented Jul 8, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 89f46f6 to 3bfc5fb Compare

July 8, 2026 13:27

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 251f943 to 14f577f Compare

July 13, 2026 14:47

github-actions Bot commented Jul 13, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

1 similar comment

github-actions Bot commented Jul 13, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime requested a review from KepoParis

July 13, 2026 15:02

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 14f577f to ef54811 Compare

July 13, 2026 15:03

github-actions Bot commented Jul 13, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from ef54811 to 64f35b1 Compare

July 15, 2026 08:36

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 64f35b1 to 43cee42 Compare

July 15, 2026 08:46

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime force-pushed the shikanime/push-plkxvsyoplqv branch from 43cee42 to 7f1834a Compare

July 15, 2026 08:51

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

4 similar comments

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime mentioned this pull request

refactor(server-nestjs): rename permission services to disambiguate #2314

Merged

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

shikanime mentioned this pull request

💡 [REQUEST] - Correction périodique des écarts sans synchronisation continue #2315

Open

4 tasks

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

5 similar comments

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

github-actions Bot commented Jul 15, 2026

Contributor

🤖 Hey !

The security scan report for the current pull request is available here.

cloud-pi-native-sonarqube Bot commented Jul 15, 2026

Quality Gate passed

Issues

Measures

Project ID: cloud-pi-native_console_AYsa46O31ebDtzs-pYyZ

View in SonarQube


          refactor(server-nestjs): replace InfrastructureModule with explicit m…

499ef61

…odule imports

Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
Change-Id: Ib0cb9dd4c83a5e8e2127eb7bd0f432926a6a6964

github-code-quality Bot found potential problems

View reviewed changes

apps/server-nestjs/src/modules/registry/registry.service.spec.ts

                     expect(vault.read).toHaveBeenCalledWith(`forge/${project.slug}/REGISTRY/ro-robot`)
                     expect(vault.read).toHaveBeenCalledWith(`forge/${project.slug}/REGISTRY/rw-robot`)
-                    expect(vault.read).toHaveBeenCalledWith(`forge/${project.slug}/REGISTRY/${projectRobotName}`)
+                    expect(vault.read).toHaveBeenCalledWith(`forge/${project.slug}/REGISTRY/${ROBOT_NAME_PROJECT}`)

apps/server-nestjs/test/registry.e2e-spec.ts

    
                  expect(robotNames).toContain(`robot$${projectSlug}+${roRobotName}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${rwRobotName}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${projectRobotName}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${ROBOT_NAME_RO}`)

apps/server-nestjs/test/registry.e2e-spec.ts

    
                  expect(robotNames).toContain(`robot$${projectSlug}+${rwRobotName}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${projectRobotName}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${ROBOT_NAME_RO}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${ROBOT_NAME_RW}`)

apps/server-nestjs/test/registry.e2e-spec.ts

    
                  expect(robotNames).toContain(`robot$${projectSlug}+${projectRobotName}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${ROBOT_NAME_RO}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${ROBOT_NAME_RW}`)

                  expect(robotNames).toContain(`robot$${projectSlug}+${ROBOT_NAME_PROJECT}`)

apps/server-nestjs/test/registry.e2e-spec.ts

    
                  expect(roSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${roRobotName}`)

                  expect(rwSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${rwRobotName}`)

                  expect(projectSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${projectRobotName}`)

                  expect(roSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${ROBOT_NAME_RO}`)

apps/server-nestjs/test/registry.e2e-spec.ts

    
                  expect(rwSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${rwRobotName}`)

                  expect(projectSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${projectRobotName}`)

                  expect(roSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${ROBOT_NAME_RO}`)

                  expect(rwSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${ROBOT_NAME_RW}`)

apps/server-nestjs/test/registry.e2e-spec.ts

    
                  expect(projectSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${projectRobotName}`)

                  expect(roSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${ROBOT_NAME_RO}`)

                  expect(rwSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${ROBOT_NAME_RW}`)

                  expect(projectSecret.data?.USERNAME).toBe(`robot$${projectSlug}+${ROBOT_NAME_PROJECT}`)

shikanime added 2 commits

July 15, 2026 14:19


          refactor(server-nestjs): cleanup constansts, tests using mockDeep and…

cf0fd92

… datastore tighter select

Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
Change-Id: Ie226a611990a4b13a64c5863c5cd90f66a6a6964


          feat(server-nestjs): add autoSync and suspended flags to plugin services

3c595d9

Signed-off-by: Shikanime Deva <william.phetsinorath@shikanime.studio>
Change-Id: I603bc405c005d1eaa9da67de8a74356b6a6a6964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

built enhancement preview tech