Skip to content

[23/36] Retire tracked PDF asset normalization - #64

Open
cjohnsto-nz wants to merge 2 commits into
release/0.8.0from
supervisor/pdf-asset-normalization
Open

[23/36] Retire tracked PDF asset normalization#64
cjohnsto-nz wants to merge 2 commits into
release/0.8.0from
supervisor/pdf-asset-normalization

Conversation

@cjohnsto-nz

@cjohnsto-nz cjohnsto-nz commented Jun 15, 2026

Copy link
Copy Markdown
Owner

Summary

  • Records that the original PDF asset line-ending rule was preventive and correct for tracked minified bundles.
  • Retires that rule because PR [22/36] Release 0.8.0 with packaged PDF.js preview #54 now generates and ignores the PDF.js assets instead of committing them.
  • Preserves this stack node with an explicit add/remove history while leaving no net file change relative to its original base.

Verification

@APKiwi

APKiwi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Verdict: approve. Pattern semantics verified: the paths contain a slash so they anchor to the repo root and match the intended media/ files. One correction to the framing: the committed blobs currently contain zero CR bytes, so this is preventive (guards contributors with core.autocrlf=true from converting on checkout/re-commit), not a fix for active corruption, and no renormalize is needed. Suggestion while you're in the file: add -diff and linguist-generated to the same two entries so the ~1MB single-line blobs stop appearing in diffs, blame and language stats.

@cjohnsto-nz cjohnsto-nz changed the title [23/36] Stabilize PDF asset line endings [23/36] Retire tracked PDF asset normalization Jul 21, 2026
@cjohnsto-nz

Copy link
Copy Markdown
Owner Author

The original review is correct: the attributes were preventive, not a repair for existing CR bytes.

PR #54 now removes the tracked PDF.js bundles and generates them from the exact build dependency, so the premise for this PR no longer exists. Commit 7ab1cf8 deletes the attributes added by 8f40105. The branch therefore preserves its place in the stack while having no net file diff from its original base:

git diff --exit-code 3ea54d2 7ab1cf8 passes.

I did not add -diff or linguist-generated. Those attributes only apply to tracked files; the PDF.js bundles are now ignored generated build output, so adding review or language-stat policy for them would be dead configuration.

Updated PR #54 → PR #64, PR #64 → PR #57, PR #64 → PR #71, and PR #64 → PR #72 all simulate cleanly. GitHub reports PR #64 and immediate child PR #57 as MERGEABLE/CLEAN, with PR #64’s fresh build and security checks passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants