[23/36] Retire tracked PDF asset normalization - #64
Conversation
|
Verdict: approve. Pattern semantics verified: the paths contain a slash so they anchor to the repo root and match the intended media/ files. One correction to the framing: the committed blobs currently contain zero CR bytes, so this is preventive (guards contributors with core.autocrlf=true from converting on checkout/re-commit), not a fix for active corruption, and no renormalize is needed. Suggestion while you're in the file: add |
|
The original review is correct: the attributes were preventive, not a repair for existing CR bytes. PR #54 now removes the tracked PDF.js bundles and generates them from the exact build dependency, so the premise for this PR no longer exists. Commit
I did not add Updated PR #54 → PR #64, PR #64 → PR #57, PR #64 → PR #71, and PR #64 → PR #72 all simulate cleanly. GitHub reports PR #64 and immediate child PR #57 as MERGEABLE/CLEAN, with PR #64’s fresh build and security checks passing. |
Summary
Verification
git diff --exit-code 3ea54d2 7ab1cf8