Skip to content

[24/36] Add OC-120 preview media controls task - #57

Open
cjohnsto-nz wants to merge 2 commits into
supervisor/pdf-asset-normalizationfrom
supervisor/add-preview-zoom-rotate-task
Open

[24/36] Add OC-120 preview media controls task#57
cjohnsto-nz wants to merge 2 commits into
supervisor/pdf-asset-normalizationfrom
supervisor/add-preview-zoom-rotate-task

Conversation

@cjohnsto-nz

@cjohnsto-nz cjohnsto-nz commented Jun 15, 2026

Copy link
Copy Markdown
Owner

Summary

Adds the supervisor planning task for preview zoom and rotate controls, including the goal prompt and task-index updates that define OC-120 scope.

Ownership

Stack

Validation

  • Task numbering and goal-prompt wiring reviewed.
  • Referenced preview surfaces and test seams match the later PR [26/36] Add OC-120 preview media controls #58 implementation.
  • GitHub reports this PR and its immediate child as mergeable.

@cjohnsto-nz
cjohnsto-nz force-pushed the supervisor/add-preview-zoom-rotate-task branch from 365910d to ad883f2 Compare June 15, 2026 07:51
@cjohnsto-nz
cjohnsto-nz changed the base branch from release/0.8.0 to supervisor/pdf-asset-normalization June 15, 2026 08:04
@cjohnsto-nz cjohnsto-nz changed the title [22/27] Add OC-120 preview media controls task [24/36] Add OC-120 preview media controls task Jun 15, 2026
@APKiwi

APKiwi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Verdict: approve. The referenced surfaces (renderPreview, response.ts, requestPanel, the pdf.js assets, the suggested test seams) all line up with what the implementation PR actually built, and the numbering/goal-prompt wiring is consistent.

@cjohnsto-nz

Copy link
Copy Markdown
Owner Author

The approval is accepted. No source change belongs on this branch.

PR #57 defines the OC-120 task, prompt, and ledger wiring. The implementation is owned by PR #58 (feature/oc-120-preview-media-controls), beginning at e9e45b0 and completed by the subsequent OC-120 commits on that branch. Adding preview code here would duplicate that ownership and increase stack conflicts.

I corrected the malformed PR body: the literal PowerShell placeholders are gone, the base/head/immediate-child branches are explicit, and the validation section now describes this documentation-only scope instead of implying that implementation artifacts belong here.

The upstream PR #64 retirement remains clean through this branch, and GitHub reports PR #57 and immediate child PR #62 as MERGEABLE/CLEAN with all checks passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants