fix: send modification notification when map indexer adds a new value. - #18
Merged
wlsnmrk merged 2 commits intoJul 1, 2026
Merged
Conversation
Note that the tests previously named "Update-" are testing the indexer, and add tests for the add behavior of the indexer. Note: One new test failing.
Fix failing test for AutoMap indexer by broadcasting a modification notification when an update op is actually an add op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
AutoMapindexer to write a new key-value pair into the map will now invoke callbacks registered viaOnModify():This behavior was failing previously.
Also added tests to verify that both
OnAdd()andOnModify()callbacks are invoked when new key-value pairs are added via indexer.(Thanks to @CaseyHofland for spotting this!)