fix: send modification notification from AutoMap.Add() with existing key - #19
Merged
wlsnmrk merged 2 commits intoJul 1, 2026
Conversation
Added tests for the update behavior of the Add() method. Note: One new test failing.
Fixed failing test for AutoMap.Add() by broadcasting a modification notification when an add op is actually an update op for an existing value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same basic bug and fix as #18, but sort of in reverse. Using
AutoMap.Add()to update an existing key will now invoke callbacks registered viaOnModify():This behavior was failing previously.
Also added tests to verify that both
OnUpdate()andOnModify()callbacks are invoked when an existing key-value pair is updated viaAdd().