Skip to content

chore: let Renovate manage the sidecar image tags in make/00_mod.mk - #715

Open
wallrj wants to merge 2 commits into
mainfrom
renovate-sidecar-images
Open

chore: let Renovate manage the sidecar image tags in make/00_mod.mk#715
wallrj wants to merge 2 commits into
mainfrom
renovate-sidecar-images

Conversation

@wallrj

@wallrj wallrj commented Aug 4, 2026

Copy link
Copy Markdown
Member

Adds a Renovate regex custom manager so that the livenessprobe and csi-node-driver-registrar tags in make/00_mod.mk are updated by Renovate (docker datasource against registry.k8s.io/sig-storage/*), instead of the manual pre-release step in RELEASE.md.

The regex matches the three-line pattern and was validated against the current file, capturing:

  • registry.k8s.io/sig-storage/livenessprobe v2.18.0
  • registry.k8s.io/sig-storage/csi-node-driver-registrar v2.16.0

Once merged, Renovate should open PRs bumping these to v2.19.0 / v2.17.0, replacing #713.

🤖 Generated with Claude Code

@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Aug 4, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hjoshi123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Renovate regex custom manager so Renovate can automatically update the pinned sidecar image tags referenced from make/00_mod.mk, replacing a manual pre-release step.

Changes:

  • Introduces a customManagers entry in Renovate config to extract depName and currentValue from make/00_mod.mk.
  • Configures the datasource as docker so Renovate can look up tags for registry.k8s.io/sig-storage/*.
Suppressed comments (1)

.github/renovate.json5:16

  • The comment describes a three-line pattern where the same <x> prefix is reused across all three lines, but the regex doesn't actually enforce that (it allows any [a-z_]+ prefix on the 2nd/3rd line). Capturing the prefix once and reusing it avoids accidental cross-block matches if additional image variables are added later, and makes the regex align with the documented intent.
      matchStrings: [
        '_image_name_source := (?<depName>\\S+)\\n[a-z_]+_image_name := \\S+\\n[a-z_]+_image_tag := (?<currentValue>v[\\d.]+)',
      ],

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/renovate.json5 Outdated
// <x>_image_tag := <version>
{
customType: 'regex',
managerFilePatterns: ['make/00_mod.mk'],

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — switched to the explicit anchored regex form /(^|/)make/00_mod\.mk$/ in both this PR and cert-manager/csi-driver-spiffe#576.

@wallrj

wallrj commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Verified this config with a local Renovate dry run from this branch (npx renovate --platform=local --dry-run=full --enabled-managers=custom.regex, after renovate-config-validator passed):

  • the anchored pattern matched only make/00_mod.mk
  • both dependencies were extracted, with the expected updates computed:
    • registry.k8s.io/sig-storage/livenessprobe v2.18.0 → v2.19.0
    • registry.k8s.io/sig-storage/csi-node-driver-registrar v2.16.0 → v2.17.0

So once this merges, Renovate's next run should open exactly the bump PR that #713 contained.

wallrj and others added 2 commits August 4, 2026 17:52
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Richard Wall <richard@the-moon.net>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Richard Wall <richard@the-moon.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants