chore: let Renovate manage the sidecar image tags in make/00_mod.mk - #715
chore: let Renovate manage the sidecar image tags in make/00_mod.mk#715wallrj wants to merge 2 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Pull request overview
This PR adds a Renovate regex custom manager so Renovate can automatically update the pinned sidecar image tags referenced from make/00_mod.mk, replacing a manual pre-release step.
Changes:
- Introduces a
customManagersentry in Renovate config to extractdepNameandcurrentValuefrommake/00_mod.mk. - Configures the datasource as
dockerso Renovate can look up tags forregistry.k8s.io/sig-storage/*.
Suppressed comments (1)
.github/renovate.json5:16
- The comment describes a three-line pattern where the same
<x>prefix is reused across all three lines, but the regex doesn't actually enforce that (it allows any[a-z_]+prefix on the 2nd/3rd line). Capturing the prefix once and reusing it avoids accidental cross-block matches if additional image variables are added later, and makes the regex align with the documented intent.
matchStrings: [
'_image_name_source := (?<depName>\\S+)\\n[a-z_]+_image_name := \\S+\\n[a-z_]+_image_tag := (?<currentValue>v[\\d.]+)',
],
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // <x>_image_tag := <version> | ||
| { | ||
| customType: 'regex', | ||
| managerFilePatterns: ['make/00_mod.mk'], |
There was a problem hiding this comment.
Good catch — switched to the explicit anchored regex form /(^|/)make/00_mod\.mk$/ in both this PR and cert-manager/csi-driver-spiffe#576.
|
Verified this config with a local Renovate dry run from this branch (
So once this merges, Renovate's next run should open exactly the bump PR that #713 contained. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
Adds a Renovate regex custom manager so that the
livenessprobeandcsi-node-driver-registrartags inmake/00_mod.mkare updated by Renovate (docker datasource againstregistry.k8s.io/sig-storage/*), instead of the manual pre-release step in RELEASE.md.The regex matches the three-line pattern and was validated against the current file, capturing:
registry.k8s.io/sig-storage/livenessprobev2.18.0registry.k8s.io/sig-storage/csi-node-driver-registrarv2.16.0Once merged, Renovate should open PRs bumping these to v2.19.0 / v2.17.0, replacing #713.
🤖 Generated with Claude Code