chore: let Renovate manage the sidecar image tags in make/00_mod.mk - #576
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
There was a problem hiding this comment.
🟡 Changes recommended
The new regex manager configuration is not robust enough as written and could mis-associate extracted values or fail to match common tag formats (e.g., pre-releases).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR configures Renovate to automatically update the livenessprobe and csi-node-driver-registrar sidecar image tags declared in make/00_mod.mk, replacing a manual release-time update step with an automated regex-based manager.
Changes:
- Adds a Renovate
customManagersentry using theregexmanager to extractdepNameandcurrentValuefrommake/00_mod.mk. - Targets the sidecar
*_image_name_source/*_image_name/*_image_tagtriple-line blocks for Docker tag updates.
File summaries
| File | Description |
|---|---|
.github/renovate.json5 |
Adds a Renovate regex custom manager intended to extract and update the sidecar image tags from make/00_mod.mk. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
Address review feedback on cert-manager/csi-driver#715: replace the generic three-line regex with two managers, each matching a single <x>_image_tag line with a hardcoded depName, and add a comment in make/00_mod.mk pointing at the Renovate config. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Richard Wall <richard@the-moon.net>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
Adds a Renovate regex custom manager so that the
livenessprobeandcsi-node-driver-registrartags inmake/00_mod.mkare updated by Renovate (docker datasource againstregistry.k8s.io/sig-storage/*), instead of the manual pre-release step in RELEASE.md.Same change as cert-manager/csi-driver#715. The regex was validated against the current file, capturing both images (currently already at the latest versions in this repo).
🤖 Generated with Claude Code