Skip to content

Consolidate trust logic into IsTrustedBuilder#2573

Draft
runesoerensen wants to merge 4 commits intobuildpacks:mainfrom
runesoerensen:runesoerensen/consolidate-trusted-builder-logic
Draft

Consolidate trust logic into IsTrustedBuilder#2573
runesoerensen wants to merge 4 commits intobuildpacks:mainfrom
runesoerensen:runesoerensen/consolidate-trusted-builder-logic

Conversation

@runesoerensen
Copy link
Copy Markdown

Summary

Note: This draft PR builds on unmerged changes introduced in #2571 - see runesoerensen/pack@runesoerensen/fix-builder-inspect-trusted...runesoerensen:pack:runesoerensen/consolidate-trusted-builder-logic to inspect only the commits introduced since that branch.

Consolidate all trust checking into IsTrustedBuilder so callers don't need to separately check IsKnownTrustedBuilder(), and use name.ParseReference for consistent reference matching across both known and user-configured builders.

  • IsTrustedBuilder now checks both known trusted builders and user-configured trusted builders
  • Uses name.ParseReference for consistent reference matching across both sources - entries without a tag match any tag in the repository, entries with a tag require an exact match
  • Remove now-unnecessary || IsKnownTrustedBuilder() calls from build.go, config_trusted_builder.go, and builder_inspect.go

Output

Before

$ pack builder inspect paketobuildpacks/builder-jammy-base:latest
...
Trusted: No

After

$ pack builder inspect paketobuildpacks/builder-jammy-base:latest
...
Trusted: Yes

Documentation

  • Should this change be documented?
    • No

Related

Resolves #2572

Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
…ilders

Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
@github-actions github-actions bot added this to the 0.41.0 milestone Apr 15, 2026
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/enhancement Issue that requests a new feature or improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trust checks are fragmented and known builders without a tag don't match tagged queries

1 participant