Separate TrustedBuilders from SuggestedBuilders#2575
Draft
runesoerensen wants to merge 7 commits intobuildpacks:mainfrom
Draft
Separate TrustedBuilders from SuggestedBuilders#2575runesoerensen wants to merge 7 commits intobuildpacks:mainfrom
TrustedBuilders from SuggestedBuilders#2575runesoerensen wants to merge 7 commits intobuildpacks:mainfrom
Conversation
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
…ilders Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
github-actions
bot
added
the
type/enhancement
Signed-off-by: Rune Soerensen <rsoerensen@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note: This draft PR builds on unmerged changes introduced in #2573 - see runesoerensen/pack@runesoerensen/consolidate-trusted-builder-logic...runesoerensen:pack:runesoerensen/separate-trusted-suggested-builders to inspect only the commits introduced since that branch.
Separate trust decisions from display metadata by splitting
KnownBuilderinto dedicated data structures for each concern.KnownBuilderstruct with separateTrustedBuilders(flat[]stringfor trust decisions) andSuggestedBuilder/SuggestedBuilders(display metadata forbuilder suggest)TrustedandSuggestedboolean fields that previously required filteringOutput
N/A - no user-facing output changes.
Documentation
Related
Resolves #2574