fix(defineShortcuts): add missing arrowdown to shiftable keys#259
Merged
Conversation
shiftableKeys listed arrowright twice and omitted arrowdown, so shift_arrowdown shortcuts never fired. Replace the duplicate with arrowdown and add the two upstream regression tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JS8ypVfQSFzYVZzkTHhURb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs upstream nuxt/ui commit
2128414— fix(defineShortcuts): add missingarrowdownto shiftable keys (#6702).What
shiftableKeyslistedarrowrighttwice and omittedarrowdown, soshift_arrowdownshortcuts never fired. Replaced the duplicatearrowrightwitharrowdown(b24ui had the identical bug atdefineShortcuts.ts:41).Ported both upstream regression tests:
shift_arrowdownfires on Shift+ArrowDown, and a barearrowdownshortcut does not fire when Shift is held.Verify (
CI=true)dev:prepare·lint·typecheck·test·build— all green. Suite 5313 passed / 6 skipped (+4 from the two new tests across the nuxt & vue projects). No snapshot changes.Ledger: cursor advanced to
2128414; previous entry64b9f7dreconciled to PR #258.🤖 Generated with Claude Code
Generated by Claude Code