fix(useFileUpload): keep dropzone type filter reactive to accept#260
Merged
Conversation
…aba4) useFileUpload passed dataTypes.value (a static snapshot) to useDropZone, so the dropzone MIME filter stopped tracking accept changes. Pass the computed dataTypes ref directly; parseAcceptToDataTypes now returns [] (no restriction) instead of undefined. Adds the upstream useFileUpload composable spec. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JS8ypVfQSFzYVZzkTHhURb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs upstream nuxt/ui commit
000aba4— fix(useFileUpload): keep dropzone type filter reactive to accept (#6699).What
useFileUploadpasseddataTypes.value— a static snapshot — touseDropZone, so the dropzone MIME filter stopped trackingacceptchanges after mount. The fix passes the computeddataTypesref directly so the filter stays reactive.parseAcceptToDataTypesnow returns[]instead ofundefinedfor unrestricted input (an empty list means "no restriction" foruseDropZone), anddataTypesis typedreadonly string[].test/composables/useFileUpload.spec.ts(composable-only; import paths are identical in b24ui) — covering drop/dialog forwarding,isDragging, accept-parsing, the reactivity regression, thedropzone: falsepath, and exposed refs.Verify (
CI=true)dev:prepare·lint·typecheck·test·build— all green. Suite 5341 passed / 6 skipped (+2 test files, 227→229). No snapshot changes.Ledger: cursor advanced to
000aba4; previous entry2128414reconciled to PR #259.🤖 Generated with Claude Code
Generated by Claude Code