chore(sync): no-op upstream Vue/Vite icon pre-bundling (dcf7cbc)#253
Merged
Conversation
Upstream dcf7cbc is the Vue/Vite build-time counterpart of the @nuxt/icon client bundle (8d46034) — a new IconsPlugin + @iconify/vue runtime plugin wired into unplugin.ts/plugins.ts, all delegating to @nuxt/icon + @iconify-json. b24ui uses @bitrix24/b24icons-vue components (no @nuxt/icon deps, none of the icon files, and its unplugin/plugins have no icon option/plugin to wire), so there is nothing to port — bookkeeping only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JS8ypVfQSFzYVZzkTHhURb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
dcf7cbc—feat(unplugin): pre-bundle used icons into the Vue/Vite build (#6635)The Vue/Vite build-time counterpart of
8d46034(@nuxt/icon client bundle): a newIconsPluginemittingvirtual:nuxt-ui-icons, an@iconify/vueruntime plugin, and wiring insrc/unplugin.ts(icon.clientBundleoption) +src/plugins/plugins.ts. All delegates to@nuxt/icon+@iconify/vue+@iconify-json/*.Decision — no-op
b24ui renders icons via
@bitrix24/b24icons-vuecomponents, not iconify:@nuxt/icon/@iconify/vue/@iconify-jsondeps.src/plugins/icons.ts,src/utils/icons.ts,src/runtime/vue/plugins/icons.ts,src/runtime/types/icons.d.ts).src/unplugin.tsandsrc/plugins/plugins.ts, but the upstream edits are pure icon-plugin wiring with no b24ui counterpart: b24ui'sunplugin.tshas no@nuxt/iconimport /icon?option /IconsPlugin, andplugins.tsregisters no icon plugin.Nothing to wire. Same basis as the earlier
@nuxt/iconno-ops (#69, #219, sibling #8d46034). Bookkeeping only:.sync/log/dcf7cbc….md— rationale.sync/nuxt-ui.json— reconcile priorc3b2996→ PR fix(FileUpload): add aria-disabled attribute when disabled #252 /365b85ad, adddcf7cbcasno-op, advance cursor🤖 Generated with Claude Code
Generated by Claude Code