test(ChatPrompt): avoid using fake timers before suspended#254
Merged
Conversation
Port of upstream nuxt/ui d0581cf (#6688). Move `vi.useFakeTimers()` to after `mountSuspended()` in the compositionend cooldown test so the fake timers don't interfere with the async suspension lifecycle. Test-only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JS8ypVfQSFzYVZzkTHhURb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream
d0581cf—test(ChatPrompt): avoid using fake timers before suspended (#6688)Change — direct 1:1 (test-only)
In
ChatPrompt.spec.ts'sre-enables submit after compositionend cooldowncase, movevi.useFakeTimers()from beforemountSuspended()to after it, so the fake timers don't interfere with the async suspension lifecycle. b24ui matched upstream.Tests
ChatPromptsuite green (62). Full suite unchanged (5289 passed / 6 skipped). No snapshot churn.Verify (CI=true)
dev:prepare·lint·test— green (nosrcchange).Ledger
.sync/log/d0581cf….md— port rationale.sync/nuxt-ui.json— addd0581cfasport, advance cursor; reconcile priordcf7cbc→ PR chore(sync): no-op upstream Vue/Vite icon pre-bundling (dcf7cbc) #253 /b13858d3.🤖 Generated with Claude Code
Generated by Claude Code