fix(TRAC-875): preserve ValidationError type in render/renderString - #404
Merged
jairo-bc merged 1 commit intoJul 13, 2026
Merged
Conversation
jairo-bc
changed the title
Helper input-validation failures (e.g. assignVar rejecting values over
1024 characters) were wrapped as RenderError, losing the ValidationError
type. Downstream consumers need to distinguish client/theme-input
faults from generic render failures in order to map them to a 4xx
instead of a 500.
Re-thrown ValidationErrors are reformatted to match RenderError's
`${message} : ${stack}` shape, so downstream log parsing keeps working.
Refs TRAC-875
jairo-bc
force-pushed
the
jairopanduro/trac-875-preserve-validation-error-type
branch
from
July 13, 2026 14:48
68e1b41 to
a28c25c
Compare
jairo-bc
marked this pull request as ready for review
July 13, 2026 15:12
rtalvarez
approved these changes
Jul 13, 2026
Contributor
|
🎉 This PR is included in version 6.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Aug 17, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: TRAC-875
What? Why?
assignVarrejecting values >1024 chars) were wrapped asRenderError, losing the originalValidationErrortyperender()/renderString()now re-throwValidationErroras-is instead of wrapping itValidationErroritselfPart of a 3-repo change (paper-handlebars → storefront-renderer-2 → storefront) downgrading these errors from 500 to 4xx.
How was it tested?
ValidationErroris rejected asValidationError(notRenderError) from bothrender()andrenderString()