fix(TRAC-1339): throw ValidationError for non-string input in urlParse and stripProtocol - #409
Closed
mfaris9 wants to merge 1 commit into
Closed
fix(TRAC-1339): throw ValidationError for non-string input in urlParse and stripProtocol#409mfaris9 wants to merge 1 commit into
mfaris9 wants to merge 1 commit into
Conversation
…e and stripProtocol Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: TRAC-1339 (LTRAC-1395)
What? Why?
urlParseandstripProtocolpassed input straight tourl.parse(), so an undefined theme variable threw a raw TypeError and 500'd the whole page renderValidationErrorfor non-string input, which the renderer preserves (fix(TRAC-875): preserve ValidationError type in render/renderString #404) so it can surface as a 4xx template error pointing at the theme instead of a 500strReplaceandencodeHtmlEntitiesHow was it tested?
ValidationErrorfor undefined, number, and object inputnpm testpasses (890 tests), coverage 97.66%npm run lintcleancc @bigcommerce/storefront-team
🤖 Generated with Claude Code