Close e2e gaps and require OTP 27+#211
Merged
Merged
Conversation
- CI: integration job now gates the build (was continue-on-error) - add e2e coverage for the multipart open_doc/stream_doc path (the most reworked hackney 4.x code, previously untested end-to-end) - drop the OTP-version crypto shim: require OTP 27+ and always use crypto:mac/4 (removes the platform_define that broke on OTP 30) - CHANGELOG: note OTP 27+ requirement and e2e testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up addressing the gaps found after the e2e work.
CI gates on e2e
The integration job was
continue-on-error: true, so the suite could fail without blocking. Removed it; the CouchDB e2e run now gates the build.Multipart open_doc coverage
The multipart
open_docreader (open_doc(Db, Id, [{attachments, true}])->{ok, {multipart, State}}->stream_doc) had no end-to-end test, despite being the most heavily reworked hackney-4.x path. Addeddoc_multipart_stream, which saves a doc with two attachments, opens it as a multipart stream, and drivesstream_doc/1to reassemble the document and each attachment byte-for-byte. Verified against CouchDB 3.3. (Note: non-compressible content types are used so CouchDB returns the bytes verbatim;text/*attachments come back gzip-encoded in multipart, which is expected.)Require OTP 27+
Dropped the
{platform_define, "^(2[3-9])", 'USE_CRYPTO_MAC'}shim and thecrypto:hmac/3fallback. couchbeam requires OTP 27+, wherecrypto:mac/4is always present. This also removes the footgun where the version regex stopped at 29 and would have fallen back to the removedcrypto:hmac/3on OTP 30.Verification
rebar3 eunit(32),dialyzer(clean), andmake e2e(all 15 groups, 65 tests against CouchDB 3.3) pass.