Remove OAuth; test against latest CouchDB 3 and 4#212
Merged
Conversation
- CI: integration job now gates the build (was continue-on-error) - add e2e coverage for the multipart open_doc/stream_doc path (the most reworked hackney 4.x code, previously untested end-to-end) - drop the OTP-version crypto shim: require OTP 27+ and always use crypto:mac/4 (removes the platform_define that broke on OTP 30) - CHANGELOG: note OTP 27+ requirement and e2e testing
- remove OAuth support: the {oauth, ...} connection option,
couchbeam_util:oauth_header/3, couchbeam_httpc:maybe_oauth_header/4, and
the optional oauth dependency (CouchDB dropped server-side OAuth in 2.x).
Basic/proxy/cookie auth are unchanged
- docker-compose + Makefile: COUCHDB_VERSION (default 3 = latest 3.x)
- CI: integration job runs a matrix of CouchDB '3' and 'latest', so 4.x is
picked up automatically once a 4.x image ships
- CHANGELOG updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #211 (merge that first; this retargets to master automatically).
Remove OAuth
CouchDB removed server-side OAuth in 2.x, so the
{oauth, ...}connection option could no longer be exercised. Removed:couchbeam_util:oauth_header/3couchbeam_httpc:maybe_oauth_header/4(and theoauthbranch inmake_headers/4)oauthdependency (deps, test deps, xref ignores, dialyzer PLT){oauth, ...}option from the docsBasic auth, proxy auth, and cookie auth are unchanged.
Latest CouchDB, matrix on latest 3 and 4
docker-compose.yml/Makefile:COUCHDB_VERSION(default3= latest 3.x); e.g.COUCHDB_VERSION=latest make e2e.couchdb: ['3', 'latest'].3is the latest 3.x;latestis 3.5.2 today and becomes 4.x the day an image ships, so CI adopts CouchDB 4 with no further change.Validation
The full e2e suite (15 groups, 65 tests) passes against both
couchdb:3andcouchdb:latest(3.5.2).rebar3 eunit(32),xref, anddialyzerare clean.Note on the one gap: CouchDB 4.x is not released (Docker
latest= 3.5.2; no 4.x or pre-release tags). Thelatestmatrix row covers it once published; nothing more to do until then.