Skip to content

34022 move director mailing validation to schema #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mruff-aeq wants to merge 2 commits into from
+7 −13
Closed

34022 move director mailing validation to schema #4562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e098ff
34022-move-director-mailing-validation-to-schema
Jul 9, 2026
1f806f2
34022-move-director-mailing-validation-to-schema
Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions legal-api/src/legal_api/services/filings/validations/change_of_directors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,13 +203,7 @@ def validate_directors_addresses(business: Business, cod: dict) -> list:
for address_type in Address.JSON_ADDRESS_TYPES:
address = director.get(address_type)

if not address:
if business.legal_type in Business.CORPS:
msg.append({
"error": f"missing {address_type}",
"path": f"/filing/changeOfDirectors/directors/{idx}/{address_type}"
})
elif address_type == Address.JSON_MAILING:
if address and address_type == Address.JSON_MAILING:
for field in mailing_required_fields:
if not address.get(field):
msg.append({
Expand Down
10 changes: 5 additions & 5 deletions python/common/business-registry-model/poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion python/common/business-registry-model/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ readme = "README.md"
requires-python = ">=3.13,<3.14"
dependencies = [
"sql-versioning @ git+https://github.com/bcgov/lear.git@main#subdirectory=python/common/sql-versioning-alt",
"registry-schemas @ git+https://github.com/bcgov/business-schemas.git@2.18.73",
"registry-schemas @ git+https://github.com/mruff-aeq/business-schemas.git@34022-director-mailingaddress-required",
"flask-migrate (>=4.1.0,<5.0.0)",
"pg8000 (>=1.31.2,<2.0.0)",
"pydantic (>=2.10.6,<3.0.0)",
Expand Down
Loading