34022 move director mailing validation to schema#4562
Closed
mruff-aeq wants to merge 2 commits into
Closed
Conversation
e31d266 to
1f806f2
Compare
|
Collaborator
Author
|
Closing — tech-debt cleanup blocked. Can't move mailingAddress to schema (shared director def, no legalType to scope by; would reject existing coop directors). Not worth pursuing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue #: /bcgov/entity#34022
Description of changes:
Removed the CORPS-only director mailingAddress presence check from legal-api since that validation now lives in the schema (directors.json requires mailingAddress); the deps temporarily reference my fork of business-schemas for pre-merge testing and will be pointed back to bcgov once the schema PR is merged and tagged.
Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).