Skip to content

test: assert Ready metric still emits for generic objects that define one #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DerekFrank wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: assert Ready metric still emits for generic objects that define one #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions status/controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1186,6 +1186,25 @@ var _ = Describe("Generic Controller", func() {
Expect(GetMetric("operator_testgenericobject_status_condition_count", conditionLabels(status.ConditionReady, metav1.ConditionUnknown))).To(BeNil())
Expect(GetMetric("operator_testgenericobject_status_condition_current_status_seconds", conditionLabels(status.ConditionReady, metav1.ConditionUnknown))).To(BeNil())
})
It("should emit a Ready condition metric for objects that define one", func() {
// Objects like corev1.Node carry a real, persisted Ready condition. Skipping
// initialization of absent conditions must not stop us from reporting a Ready
// that is actually present on the object.
testObject := test.Object(&TestGenericObject{})
gvk := object.GVK(testObject)
testObject.Status = TestGenericStatus{
Conditions: []metav1.Condition{
{Type: status.ConditionReady, Status: metav1.ConditionTrue},
},
}

ExpectApplied(ctx, kubeClient, testObject)
ExpectReconciled(ctx, genericController, testObject)

Expect(GetMetric("operator_status_condition_count", conditionLabelsWithGroupKind(gvk, status.ConditionReady, metav1.ConditionTrue)).GetGauge().GetValue()).To(BeEquivalentTo(1))
Expect(GetMetric("operator_status_condition_current_status_seconds", conditionLabelsWithGroupKind(gvk, status.ConditionReady, metav1.ConditionTrue)).GetGauge().GetValue()).ToNot(BeZero())
Expect(GetMetric("operator_testgenericobject_status_condition_count", conditionLabels(status.ConditionReady, metav1.ConditionTrue)).GetGauge().GetValue()).To(BeEquivalentTo(1))
})
It("should emit transition total metrics for abnormal conditions", func() {
testObject := test.Object(&TestGenericObject{})
gvk := object.GVK(testObject)
Expand Down