test: assert Ready metric still emits for generic objects that define one#213
Open
DerekFrank wants to merge 1 commit into
Open
test: assert Ready metric still emits for generic objects that define one#213DerekFrank wants to merge 1 commit into
DerekFrank wants to merge 1 commit into
Conversation
… one Follow-up to awslabs#212. That PR stopped the GenericObjectController from fabricating a phantom Ready=Unknown metric for objects without a Ready condition, and tested the absent-Ready case. This adds the complementary case: an object that carries a real, persisted Ready condition (e.g. corev1.Node) must still emit its Ready metric — confirming the observed-only change filters only fabricated conditions, not present ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #212.
#212 stopped the
GenericObjectControllerfrom fabricating a phantomReady=Unknownmetric for objects that don't define aReadycondition, and added a test for that absent-Readycase.This adds the complementary case: an object that carries a real, persisted
Readycondition (e.g.corev1.Node, whoseReadyis set by kubelet) must still emit itsReadymetric. This confirms theWithObservedOnlychange filters only fabricated conditions, not ones actually present on the object — i.e. no regression to the Node/NodeClaim/NodePool Ready metrics that legitimately flow through this path.Test-only; passes against current main.