Skip to content

Enable default oxlint correctness rules #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmcginnes merged 1 commit into from
May 5, 2026
Merged

Enable default oxlint correctness rules #1748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
222 changes: 65 additions & 157 deletions .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,69 +1,30 @@
{
"$schema": "./node_modules/oxlint/configuration_schema.json",
"plugins": ["typescript", "unicorn"],
"plugins": [
"eslint",
"oxc",
"typescript",
"unicorn",
"import",
"vitest",
"promise"
],
"options": {
"typeAware": true
},
"categories": {
// Disabled so rules are enabled explicitly below for full control.
// New oxlint correctness rules won't auto-enable on upgrades.
"correctness": "off"
"correctness": "error"
},
"env": {
"builtin": true
},
"ignorePatterns": ["**/*.config.{js,ts,mjs}", "**/vitest.workspace.ts"],
"rules": {
"constructor-super": "error",
"for-direction": "error",
"getter-return": "error",
"no-async-promise-executor": "error",
"no-case-declarations": "error",
"no-class-assign": "error",
"no-compare-neg-zero": "error",
"no-cond-assign": "error",
"no-const-assign": "error",
"no-constant-binary-expression": "error",
"no-constant-condition": "error",
"no-control-regex": "error",
"no-debugger": "error",
"no-delete-var": "error",
"no-dupe-class-members": "error",
"no-dupe-else-if": "error",
"no-dupe-keys": "error",
"no-duplicate-case": "error",
"no-empty": "error",
"no-empty-character-class": "error",
"no-empty-pattern": "error",
"no-empty-static-block": "error",
"no-ex-assign": "error",
"no-extra-boolean-cast": "error",
"no-fallthrough": "error",
"no-func-assign": "error",
"no-global-assign": "error",
"no-import-assign": "error",
"no-invalid-regexp": "error",
"no-irregular-whitespace": "error",
"no-loss-of-precision": "error",
"no-misleading-character-class": "error",
"no-new-native-nonconstructor": "error",
"no-nonoctal-decimal-escape": "error",
"no-obj-calls": "error",
"no-prototype-builtins": "error",
"no-redeclare": "error",
"no-regex-spaces": "error",
"no-self-assign": "error",
"no-setter-return": "error",
"no-shadow-restricted-names": "error",
"no-sparse-arrays": "error",
"no-this-before-super": "error",
"no-unassigned-vars": "error",
"no-unsafe-finally": "error",
"no-unsafe-negation": "error",
"no-unsafe-optional-chaining": "error",
"no-unreachable": "error",
"no-unused-labels": "error",
"no-unused-private-class-members": "error",
"vitest/require-mock-type-parameters": "off",
"jest/require-to-throw-message": "off",
"jest/valid-expect": "off",
"typescript/unbound-method": "off",
"typescript/no-floating-promises": "off",
"no-unused-vars": [
"error",
{
Expand All @@ -72,106 +33,33 @@
"caughtErrorsIgnorePattern": "^_"
}
],
"no-useless-backreference": "error",
"no-useless-catch": "error",
"no-useless-escape": "error",
"no-with": "error",
"preserve-caught-error": "error",
"require-yield": "error",
"use-isnan": "error",
"valid-typeof": "error",
"no-array-constructor": "error",
"no-console": [
"no-console": ["error", { "allow": ["warn", "error"] }],
"typescript/consistent-type-imports": [
"error",
{
"allow": ["warn", "error"]
}
{ "fixStyle": "inline-type-imports" }
],
"no-caller": "error",
"no-eval": "error",
"no-iterator": "error",
"no-useless-rename": "error",

// oxc rules
"bad-array-method-on-arguments": "error",
"bad-char-at-comparison": "error",
"bad-comparison-sequence": "error",
"bad-min-max-func": "error",
"bad-object-literal-comparison": "error",
"bad-replace-all-arg": "error",
"const-comparisons": "error",
"double-comparisons": "error",
"erasing-op": "error",
"missing-throw": "error",
"number-arg-out-of-range": "error",
"only-used-in-recursion": "error",
"uninvoked-array-callback": "error",

// unicorn rules
"unicorn/no-await-in-promise-methods": "error",
"unicorn/no-empty-file": "error",
"unicorn/no-invalid-fetch-options": "error",
"unicorn/no-invalid-remove-event-listener": "error",
"unicorn/no-new-array": "error",
"unicorn/no-single-promise-in-promise-methods": "error",
"unicorn/no-thenable": "error",
"unicorn/no-unnecessary-await": "error",
"unicorn/no-useless-spread": "error",
"unicorn/prefer-set-size": "error",
"typescript/no-import-type-side-effects": "error",
"typescript/switch-exhaustiveness-check": "error",
"no-case-declarations": "error",
"no-empty": "error",
"no-fallthrough": "error",
"no-prototype-builtins": "error",
"no-redeclare": "error",
"no-regex-spaces": "error",
"preserve-caught-error": "error",
"no-array-constructor": "error",
"typescript/ban-ts-comment": "error",
"typescript/no-duplicate-enum-values": "error",
"typescript/no-empty-object-type": "error",
"typescript/no-extra-non-null-assertion": "error",
"typescript/no-misused-new": "error",
"typescript/no-namespace": "error",
"typescript/no-non-null-asserted-optional-chain": "error",
"typescript/no-require-imports": "error",
"typescript/no-this-alias": "error",
"typescript/no-unnecessary-type-constraint": "error",
"typescript/no-unsafe-declaration-merging": "error",
"typescript/no-unsafe-function-type": "error",
"typescript/no-wrapper-object-types": "error",
"typescript/prefer-as-const": "error",
"typescript/prefer-namespace-keyword": "error",
"typescript/triple-slash-reference": "error",
"typescript/consistent-type-imports": [
"error",
{
"fixStyle": "inline-type-imports"
}
],
"typescript/no-import-type-side-effects": "error",
"typescript/no-unnecessary-parameter-property-assignment": "error",
"typescript/no-useless-empty-export": "error",

// Type-aware rules (from typescript-eslint recommendedTypeChecked)
"typescript/await-thenable": "error",
"typescript/no-array-delete": "error",
"typescript/no-base-to-string": "error",
"typescript/no-duplicate-type-constituents": "error",
"typescript/no-for-in-array": "error",
"typescript/no-implied-eval": "error",
"typescript/no-redundant-type-constituents": "error",
"typescript/no-unnecessary-type-assertion": "error",
"typescript/no-unsafe-enum-comparison": "error",
"typescript/no-unsafe-unary-minus": "error",
"typescript/only-throw-error": "error",
"typescript/prefer-promise-reject-errors": "error",
"typescript/require-await": "error",
"typescript/restrict-plus-operands": "error",
"typescript/restrict-template-expressions": "error",
"typescript/switch-exhaustiveness-check": "error",
"typescript/require-array-sort-compare": "error",

// Type-aware rules explicitly disabled
"typescript/no-unsafe-argument": "off",
"typescript/no-unsafe-assignment": "off",
"typescript/no-unsafe-call": "off",
"typescript/no-unsafe-member-access": "off",
"typescript/no-unsafe-return": "off",
"typescript/unbound-method": "off",
"typescript/no-floating-promises": "off",
"typescript/no-misused-promises": "off"
"typescript/restrict-plus-operands": "error"
},
"overrides": [
{
Expand Down Expand Up @@ -199,12 +87,38 @@
},
{
"files": ["packages/graph-explorer/**/*.{ts,tsx}"],
"plugins": ["react", "react-perf", "jsx-a11y"],
"jsPlugins": [
"@tanstack/eslint-plugin-query",
{ "name": "react-compiler", "specifier": "eslint-plugin-react-hooks" }
],
"env": { "browser": true },
"rules": {
"react/display-name": "off",
"react/no-unsafe": "error",
"react/react-in-jsx-scope": "off",
"jsx-a11y/no-autofocus": "off",
"jsx-a11y/click-events-have-key-events": "off",
"jsx-a11y/no-static-element-interactions": "off",
"jsx-a11y/mouse-events-have-key-events": "off",
"react-compiler/rules-of-hooks": "off",
"react-compiler/exhaustive-deps": "off",
"react-compiler/config": "error",
"react-compiler/error-boundaries": "error",
"react-compiler/gating": "error",
"react-compiler/globals": "error",
"react-compiler/immutability": "error",
"react-compiler/incompatible-library": "warn",
"react-compiler/preserve-manual-memoization": "error",
"react-compiler/purity": "error",
"react-compiler/refs": "error",
"react-compiler/set-state-in-effect": "error",
"react-compiler/set-state-in-render": "error",
"react-compiler/static-components": "error",
"react-compiler/unsupported-syntax": "warn",
"react-compiler/use-memo": "error",
"react/jsx-key": "error",
"react/jsx-no-comment-textnodes": "error",
"react/jsx-no-duplicate-props": "error",
"react/jsx-no-target-blank": "error",
"react/jsx-no-undef": "error",
"react/no-children-prop": "error",
"react/no-danger-with-children": "error",
Expand All @@ -213,32 +127,26 @@
"react/no-is-mounted": "error",
"react/no-render-return-value": "error",
"react/no-string-refs": "error",
"react/jsx-no-comment-textnodes": "error",
"react/jsx-no-target-blank": "error",
"react/no-unescaped-entities": "error",
"react/no-unknown-property": "error",
"react/no-unsafe": "off",
"react/react-in-jsx-scope": "off",
"react/jsx-curly-brace-presence": "error",
"react/rules-of-hooks": "error",
"react/exhaustive-deps": "warn",
"@tanstack/query/exhaustive-deps": "error",
"@tanstack/query/no-rest-destructuring": "warn",
"@tanstack/query/stable-query-client": "error",
"@tanstack/query/no-unstable-deps": "error",
"@tanstack/query/infinite-query-property-order": "error",
"@tanstack/query/no-void-query-fn": "error",
"@tanstack/query/mutation-property-order": "error",
"react/jsx-curly-brace-presence": "error",
"react/rules-of-hooks": "error",
"react/exhaustive-deps": "warn"
},
"jsPlugins": ["@tanstack/eslint-plugin-query"],
"plugins": ["react"],
"env": {
"browser": true
"@tanstack/query/mutation-property-order": "error"
}
},
{
"files": ["packages/graph-explorer-proxy-server/**/*.{ts,js}"],
"env": {
"node": true
}
"plugins": ["node"],
"env": { "node": true }
}
]
}
36 changes: 0 additions & 36 deletions eslint.config.mjs
View file
Open in desktop

This file was deleted.

8 changes: 2 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"type": "module",
"scripts": {
"prepare": "husky",
"lint": "oxlint --fix && eslint --fix",
"check:lint": "oxlint && eslint",
"lint": "oxlint --fix",
"check:lint": "oxlint",
"format": "oxfmt",
"check:format": "oxfmt --check",
"test": "vitest run",
Expand All @@ -29,23 +29,19 @@
"@types/node": "^24.10.9",
"@vitest/coverage-v8": "4.1.5",
"babel-plugin-react-compiler": "^1.0.0",
"eslint": "^10.2.1",
"eslint-plugin-oxlint": "1.62.0",
"eslint-plugin-react-hooks": "7.1.1",
"husky": "^9.1.7",
"lint-staged": "^16.4.0",
"oxfmt": "^0.47.0",
"oxlint": "1.62.0",
"oxlint-tsgolint": "0.22.1",
"typescript": "^6.0.3",
"typescript-eslint": "^8.59.1",
"vitest": "4.1.5"
},
"lint-staged": {
"!(**/*.{js,ts,tsx})": "oxfmt --no-error-on-unmatched-pattern",
"**/*.{js,ts,tsx}": [
"oxlint --fix",
"eslint --fix",
"oxfmt"
]
},
Expand Down
4 changes: 2 additions & 2 deletions packages/graph-explorer-proxy-server/src/app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ describe("createApp", () => {
await request(app).post("/sparql").set(dbHeaders()).send({ query });

const fetchOptions = mockFetch.mock.calls[0][1] as any;
expect(fetchOptions.headers["Content-Type"]).toBe(
expect(fetchOptions.headers["content-type"]).toBe(
"application/x-www-form-urlencoded",
);
expect(fetchOptions.body).toContain(`query=${encodeURIComponent(query)}`);
Expand Down Expand Up @@ -503,7 +503,7 @@ describe("createApp", () => {
await request(app).post("/openCypher").set(dbHeaders()).send({ query });

const fetchOptions = mockFetch.mock.calls[0][1] as any;
expect(fetchOptions.headers["Content-Type"]).toBe(
expect(fetchOptions.headers["content-type"]).toBe(
"application/x-www-form-urlencoded",
);
expect(fetchOptions.body).toBe(`query=${encodeURIComponent(query)}`);
Expand Down
5 changes: 4 additions & 1 deletion packages/graph-explorer-proxy-server/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,10 @@ export function createApp({
new URL(url),
{
...options,
headers: { "User-Agent": userAgent, ...options.headers },
headers: {
"User-Agent": userAgent,
...Object.fromEntries(new Headers(options.headers as HeadersInit)),
},
},
isIamEnabled,
region,
Expand Down
1 change: 1 addition & 0 deletions packages/graph-explorer-proxy-server/src/error-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ function extractErrorInfo(error: unknown) {

if (error instanceof Error) {
return {
// oxlint-disable-next-line typescript/no-misused-spread -- Intentionally extracting Error properties for serialization
...error,
status: getStatusFromError(error),
message: error.message || defaultErrorMessage,
Expand Down
Loading
Loading