Enable default oxlint correctness rules#1748
Merged
Conversation
b6db086 to
a93b3e5
Compare
a93b3e5 to
8b01806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes 39 lint violations and flips the oxlint
correctnesscategory from"off"to"error". This means new correctness rules will be automatically enabled on oxlint upgrades.no-unused-expressions(13) — convert ternary/&&statements toif/elseno-useless-fallback-in-spread(13) — remove unnecessary|| {}from spreadsno-misused-spread(6) — fix unsafe spreads of arrays/iterables in objects; add disable comments for intentional MouseEvent/Error property extractionno-meaningless-void-operator(4) — removevoidfrom already-void callsno-useless-length-check(2) — remove redundant.length > 0before.some()no-useless-default-assignment(1) — remove default on non-nullish property.oxlintrc.json— remove ~60 individual rule entries now redundant with the category defaultValidation
pnpm checkspasses (119 rules, 0 errors)pnpm testpasses (153 files, 1660 tests)Related Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.