Add public artifact dash hook#68
Conversation
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
2295ab8 to
45e1141
Compare
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
45e1141 to
2336b0c
Compare
ariobarin
force-pushed
the
codex/modular-doctor-hooks
branch
from
118392d to
0fc3952
Compare
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
2336b0c to
c762bea
Compare
ariobarin
force-pushed
the
codex/modular-doctor-hooks
branch
from
0fc3952 to
e90232f
Compare
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
c762bea to
a46abe2
Compare
ariobarin
force-pushed
the
codex/modular-doctor-hooks
branch
from
e90232f to
fa60fe9
Compare
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
a46abe2 to
3819b51
Compare
ariobarin
force-pushed
the
codex/modular-doctor-hooks
branch
from
fa60fe9 to
0e434b4
Compare
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
3819b51 to
87e9035
Compare
ariobarin
force-pushed
the
codex/modular-doctor-hooks
branch
from
0e434b4 to
c8900d7
Compare
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
87e9035 to
f060ee2
Compare
ariobarin
force-pushed
the
codex/modular-doctor-hooks
branch
from
c8900d7 to
955c719
Compare
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
f060ee2 to
02575b7
Compare
ariobarin
force-pushed
the
codex/modular-doctor-hooks
branch
from
955c719 to
fc969f6
Compare
ariobarin
force-pushed
the
codex/hook-dash-guard
branch
from
02575b7 to
f48d5ad
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f48d5ad368
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| DASH_CHARS = chr(0x2013) + chr(0x2014) | ||
| SHELL_ARG = r'"[^"]+"|\'[^\']+\'|\S+' | ||
| PUBLIC_COMMAND_RE = re.compile( | ||
| rf"\b(git(?:\s+(?:(?:-C|--git-dir|--work-tree|--namespace)\s+(?:{SHELL_ARG})|-c\s+(?:[^\s=]+=(?:{SHELL_ARG})|(?:{SHELL_ARG}))|--[A-Za-z0-9-]+=(?:{SHELL_ARG})|--[A-Za-z0-9-]+|-[A-Za-z]+))*\s+(?:commit|tag)|gh(?:\s+(?:(?:--repo|-R)\s+(?:{SHELL_ARG})|--repo=(?:{SHELL_ARG})))*\s+pr\s+\S+|gh\s+release)\b", |
There was a problem hiding this comment.
When a release command targets another repo with -R or --repo before the subcommand, this regex falls through to the bare gh\s+release alternative, so gh --repo owner/repo release create ... --title <text containing U+2014> is allowed. The GitHub CLI manual for gh release create lists inherited -R, --repo <[HOST/]OWNER/REPO> to select another repository (https://cli.github.com/manual/gh_release_create), and the PR branch just above already handles those repo flags, so this leaves a common release-publishing path outside the new guard.
Useful? React with 👍 / 👎.
1 participant
Keeps public git and GitHub text from carrying Unicode dash characters before the portable hook set grows further.