Add portable Codex hooks#7
Conversation
ariobarin
force-pushed
the
codex/portable-hooks
branch
from
2ac7d3f to
a2cfd69
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2cfd6908a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "command": "python3 ~/.codex/hooks/portable_guard.py", | ||
| "commandWindows": "python -c \"import os, runpy; runpy.run_path(os.path.join(os.environ['USERPROFILE'], '.codex', 'hooks', 'portable_guard.py'), run_name='__main__')\"", |
There was a problem hiding this comment.
When scripts/install.ps1 -CodexHome <path> -Apply is used, the map in Get-PortableFileMap copies both hooks.json and hooks/ into that custom home, but this command still executes the guard from ~/.codex (and the Windows override uses %USERPROFILE%\.codex). That makes a custom-home install run a missing or stale guard rather than the script it just installed, so the new hooks lose their protection outside the default profile.
Useful? React with 👍 / 👎.
| PUBLIC_COMMAND_RE = re.compile( | ||
| r"\b(git\s+commit|git\s+tag|gh\s+pr\s+(create|edit)|gh\s+release)\b", | ||
| re.IGNORECASE, |
There was a problem hiding this comment.
Git's own usage allows global options before the subcommand (git [-C <path>] ... <command>, from git --help), but this regex only matches git followed immediately by commit or tag. Commands like git -C repo commit -m "<message with an em dash>" therefore pass through dash_guard even though they create public artifacts with Unicode dashes, which defeats the guard in the common git -C or git -c workflow.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cae356990d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| **Always start with `--design-system`** to get comprehensive recommendations with reasoning: | ||
|
|
||
| ```bash | ||
| python3 skills/ui-ux-pro-max/scripts/search.py "<product_type> <industry> <keywords>" --design-system [-p "Project Name"] |
There was a problem hiding this comment.
These commands are shown as skills/ui-ux-pro-max/..., but after this portable repo installs the skill it lives under ~/.codex/skills/ui-ux-pro-max, and Codex runs from the target project cwd; there is normally no project-local skills/ directory, so the required Step 2 command fails before any search runs. Use the skill-local scripts/search.py path or an absolute Codex-home path in all examples.
Useful? React with 👍 / 👎.
| project_name = design_system.get("project_name", "default") | ||
| project_slug = project_name.lower().replace(' ', '-') | ||
|
|
||
| design_system_dir = base_dir / "design-system" / project_slug |
There was a problem hiding this comment.
Persisting always creates design-system/<project_slug>/..., but the generated MASTER/page files and the skill instructions direct agents to design-system/MASTER.md and design-system/pages/.... In any --persist -p run, those documented locations do not exist, so future sessions following the generated instructions miss the persisted rules and page overrides; either persist to the documented root or include the project slug in all retrieval guidance.
Useful? React with 👍 / 👎.
| python search.py "<query>" --design-system [-p "Project Name"] | ||
| python search.py "<query>" --design-system --persist [-p "Project Name"] [--page "dashboard"] | ||
|
|
||
| Domains: style, prompt, color, chart, landing, product, ux, typography, google-fonts |
There was a problem hiding this comment.
The CLI docs advertise prompt as a domain, but argparse restricts --domain to CSV_CONFIG.keys() and there is no prompt entry in core.py; running the documented --domain prompt "minimalism" exits with an invalid-choice error instead of returning CSS prompt keywords. Remove the advertised domain or add the missing CSV config.
Useful? React with 👍 / 👎.
|
|
||
| # Print persistence confirmation | ||
| if args.persist: | ||
| project_slug = args.project_name.lower().replace(' ', '-') if args.project_name else "default" |
There was a problem hiding this comment.
When --persist is used without -p, generate_design_system names the project from the query and writes to a slug such as design-system/saas-dashboard/, but this confirmation prints design-system/default/; users following the success output will look in a non-existent directory. Derive the printed slug from the same project name used by persist_design_system.
Useful? React with 👍 / 👎.
ariobarin
force-pushed
the
codex/portable-hooks
branch
from
cae3569 to
e411e43
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e411e437ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| DASH_CHARS = chr(0x2013) + chr(0x2014) | ||
| PUBLIC_COMMAND_RE = re.compile( | ||
| r"\b(git\s+commit|git\s+tag|gh\s+pr\s+\S+|gh\s+release)\b", |
There was a problem hiding this comment.
When the agent uses Git's documented global options before the subcommand, git --help shows git [-C <path>] [-c <name>=<value>] ... <command>, this regex does not match. A command such as git -C repo commit -m "bad U+2014 msg" therefore bypasses the PreToolUse dash guard and can publish the exact character the hook is meant to deny. Please allow optional Git global options before commit and tag.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 910cc232ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| DASH_CHARS = chr(0x2013) + chr(0x2014) | ||
| PUBLIC_COMMAND_RE = re.compile( | ||
| r"\b(git\s+commit|git\s+tag|gh\s+pr\s+\S+|gh\s+release)\b", |
There was a problem hiding this comment.
When Codex runs a public artifact command with common Git global options, such as git -C /workspace/repo commit -m "x<U+2014>y" or git -c safe.directory=... tag ..., this regex does not match because it requires git to be followed immediately by commit or tag. Since the PreToolUse hook denies only after PUBLIC_COMMAND_RE.search(command), those commit and tag commands can still publish U+2013/U+2014 characters despite the guard's stated purpose.
Useful? React with 👍 / 👎.
| root = git_root(cwd) | ||
| if root is not None: | ||
| repos.append(root) | ||
| else: |
There was a problem hiding this comment.
If Codex is started from a directory that is itself a Git repo, this else prevents scanning any immediate child repositories. In a workspace where child repos are ignored by the parent, a dirty or unpushed child repo is silently omitted from the Stop continuation, contradicting the hook README's promise to report the current repo or immediate child repos before the final answer.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6050fffce4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| DASH_CHARS = chr(0x2013) + chr(0x2014) | ||
| PUBLIC_COMMAND_RE = re.compile( | ||
| r"\b(git\s+commit|git\s+tag|gh(?:\s+(?:--repo|-R)\s+\S+)*\s+pr\s+\S+|gh\s+release)\b", |
There was a problem hiding this comment.
When a Bash command uses Git global options before the subcommand, for example git -C ../repo commit -m 'bad \u2014 title', this regex does not match because it only accepts git\s+commit or git\s+tag immediately after git. I checked git -h, which allows global options before <command>, so multi-repo or out-of-tree workflows can still create commits and tags with U+2013/U+2014 text without the guard firing.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13ade802d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| body = [line for line in lines[1:] if line.strip()] | ||
| header = lines[0] | ||
| has_ahead = "[ahead " in header or "ahead " in header | ||
| no_upstream = "..." not in header and not header.endswith("main") and not header.endswith("master") |
There was a problem hiding this comment.
When a clean repo is on any local branch whose short status header has no upstream, for example ## topic, this sets no_upstream and the Stop hook returns decision: "block" even though there are no dirty files or known unpushed commits. I verified this by running the hook in a freshly committed temp repo on a topic branch with no upstream, which produced a required continuation saying no upstream shown; that makes normal final answers continue once and report spurious leftover state.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f61c59ff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| body = [line for line in lines[1:] if line.strip()] | ||
| header = lines[0] | ||
| has_ahead = "[ahead " in header or "ahead " in header | ||
| no_upstream = "..." not in header and not header.endswith("main") and not header.endswith("master") |
There was a problem hiding this comment.
When a repo is on a clean local branch that has no upstream, git status --short --branch produces only a header like ## work; this predicate makes repo_status_summary return no upstream shown even though there are no dirty files or proven unpushed commits. Because the Stop hook then emits decision: "block", every final answer in that normal local-branch setup gets forced into an extra continuation, which is noisier than the documented dirty or unpushed closeout behavior.
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4e2f3c515
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| body = [line for line in lines[1:] if line.strip()] | ||
| header = lines[0] | ||
| has_ahead = "[ahead " in header or "ahead " in header |
There was a problem hiding this comment.
For a clean branch that has local commits but no configured upstream, such as after git switch -c feature and a local commit before the first push, git status --short --branch only reports the branch name, so has_ahead stays false and this function returns None. The Stop hook then skips the continuation and fails to mention the unpushed-commit state it was added to catch; compare commits against remotes or explicitly handle branches with no upstream instead of only looking for [ahead ...].
Useful? React with 👍 / 👎.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 871257d224
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| has_no_upstream = "..." not in header | ||
| has_unpushed_no_upstream = has_no_upstream and head_missing_from_remotes(repo) |
There was a problem hiding this comment.
When a branch tracks an upstream ref that has since been deleted, git status --short --branch reports a header like ## feature...origin/feature [gone], even if HEAD has local commits no current remote ref contains. Because this only calls head_missing_from_remotes() when the header lacks ..., those clean branches produce no Stop hook output, so the final answer omits the unpushed state this hook is meant to surface.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Carries global Codex hooks through the portable install path so they can be reviewed and moved between machines.