engine: restore reproducible package, tests, CI, and human-first controls#3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Resolve DP-001 by making the DailyPilot reference engine reproducibly importable, testable, executable, and accurately documented.
Closes #2.
Root causes corrected
The repository claimed an
engine.core.*architecture, but implementation files and profiles were located at the root. Tests and CLI therefore referenced paths that did not exist in a clean checkout. The rootselectors.pyfilename also risked shadowing Python's standard-libraryselectorsmodule.Changes
Executable architecture
enginePython package.engine.core.engine/profiles.engine.core.__init__.CLI reliability
engine.core.YYYY-MM-DDdue dates.Evidence and CI
Public trust controls
SECURITY.md..github/CODEOWNERS.max_stress_loadis not currently enforced.Scope and compatibility
This is a package-layout correction for a reference implementation whose documentation and tests already claimed the
engine.coreimport path. Root-level imports such asfrom models import Taskare intentionally removed because they were not the documented architecture and created collision risk.Security and privacy
Validation
Independent reconstruction and execution completed successfully:
python -m pytest -q: 6 passedpython dailypilot_cli.py sample_day.json --profile worker_double_shift: passed and wrote a local run logGitHub Actions runs
29259034440and29259157659failed before any step executed and returned no job logs. This is tracked in #4 as a runner/account/policy infrastructure blocker rather than represented as a code failure.Merge gate
Keep this PR open until hosted CI executes successfully or an attributable exception is approved and recorded. Rollback after merge would be a squash-commit revert.
AI assistance disclosure
P.A.I.H.I.
Decision class
Material engineering and governance change.
Authorization
All Clear for Impact: Approved