Skip to content

feat(graph): add full_verify preset — one-command build->spec->test->review #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alpibrupa merged 1 commit into from
Sep 5, 2026
Merged

feat(graph): add full_verify preset — one-command build->spec->test->review #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions src/server/graph.lex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,21 @@ fn impl_then_spec_then_test() -> Node {
SequenceNode([AgentNode(build_def()), AgentNode(spec_def()), ParallelNode([AgentNode(test_def()), AgentNode(review_def())])])
}

# #120's "one-command full verify": build, then spec, then test, then
# review — each stage strictly after the last, unlike
# impl_then_spec_then_test's parallel test/review tail. review here
# reviews what test already checked, not the same untested output test
# is concurrently checking.
fn full_verify() -> Node {
SequenceNode([AgentNode(build_def()), AgentNode(spec_def()), AgentNode(test_def()), AgentNode(review_def())])
}

fn preset_names() -> List[Str]
examples {
preset_names() => ["impl_then_test", "impl_and_test_parallel", "impl_then_spec_then_test"]
preset_names() => ["impl_then_test", "impl_and_test_parallel", "impl_then_spec_then_test", "full_verify"]
}
{
["impl_then_test", "impl_and_test_parallel", "impl_then_spec_then_test"]
["impl_then_test", "impl_and_test_parallel", "impl_then_spec_then_test", "full_verify"]
}

# Resolve a pipeline name from the command line. Unknown names are None
Expand All @@ -97,7 +106,11 @@ fn preset(name :: Str) -> Option[Node] {
if name == "impl_then_spec_then_test" {
Some(impl_then_spec_then_test())
} else {
None
if name == "full_verify" {
Some(full_verify())
} else {
None
}
}
}
}
Expand All @@ -112,6 +125,7 @@ fn preset_shape(name :: Str) -> Str
preset_shape("impl_then_test") => "impl → test",
preset_shape("impl_and_test_parallel") => "impl ∥ test",
preset_shape("impl_then_spec_then_test") => "impl → spec → (test ∥ review)",
preset_shape("full_verify") => "impl → spec → test → review",
preset_shape("nope") => ""
}
{
Expand All @@ -126,6 +140,7 @@ fn is_preset(name :: Str) -> Bool
is_preset("impl_then_test") => true,
is_preset("impl_and_test_parallel") => true,
is_preset("impl_then_spec_then_test") => true,
is_preset("full_verify") => true,
is_preset("build") => false,
is_preset("") => false
}
Expand Down Expand Up @@ -280,7 +295,11 @@ fn spec_matches_preset() -> Bool
{
if spec_shape("build,test") == preset_shape("impl_then_test") {
if spec_shape("build|test") == preset_shape("impl_and_test_parallel") {
spec_shape("build,spec,test|review") == preset_shape("impl_then_spec_then_test")
if spec_shape("build,spec,test|review") == preset_shape("impl_then_spec_then_test") {
spec_shape("build,spec,test,review") == preset_shape("full_verify")
} else {
false
}
} else {
false
}
Expand Down
Loading